-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to removed WithOpenShiftTestServer functionality #45443
Conversation
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
…Server functionality Signed-off-by: Marc Nuri <marc@marcnuri.com>
414afa4
to
a07da0c
Compare
Status for workflow
|
Status for workflow
|
@geoand Reading this, something interesting to note is that I'm not sure if we should change that or have two different annotations? Maybe I noticed that while investigating the sbomer test suite slowness. Also @manusa could you write some Asciidoc content for me to include in the migration guide? Thanks! |
Nice catch!
That's probably better! |
It's funny because I actually spent some time trying to understand why there were two different MockWebServer instances spawning when I launched the test. I eventually realized that the other instance came from a different test which had an annotation that behaves as you describe. The MockWebServer starts really quickly. IMO it's better to have an instance per class/suite, so the actual behavior of the So I'd vote for a
Sure, I'll create some content and put it in the original issue #44899 and ping you there. |
Yeah so it's not about the MockServer being slow, it's about potentially requiring a lot more Quarkus restarts when running the tests. |
Description
Follows up on #45259 as part of #44899
Remove/Replace mentions in the kubernetes-client guide of OpenShift mockserver (
quarkus-test-openshift-client
).Additionally added a test to ensure that OpenShift client injection from the Kubernetes MockServer works as expected.
/cc @metacosm