Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[oracle-jdbc] Remove unnecessary conditionals from @BuildSteps in the Oracle JDBC extension" #45576

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jan 14, 2025

This reverts commit 19d9ed1.

See #41998 (comment) and follow-ups for context.

@mabartos would it work for you?

…in the Oracle JDBC extension"

This reverts commit 19d9ed1.
@quarkus-bot quarkus-bot bot added the area/jdbc Issues related to the JDBC extensions label Jan 14, 2025
Copy link
Contributor

@mabartos mabartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet LGTM, thanks!

Would it also be possible to backport it to 3.15.x?

I'll post more information on the mentioned issue.

@gsmet
Copy link
Member Author

gsmet commented Jan 14, 2025

3.15.3 is already on its way but we can consider it for the next one (added label to have it in the loop).

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 14, 2025
Copy link

quarkus-bot bot commented Jan 14, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 134637c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi gastaldi merged commit 9efb549 into quarkusio:main Jan 14, 2025
21 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 14, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 14, 2025
@gsmet gsmet modified the milestones: 3.18 - main, 3.17.7 Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jdbc Issues related to the JDBC extensions triage/backport-3.15
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants