Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.17] 3.17.7 backports 1 #45590

Merged
merged 18 commits into from
Jan 15, 2025
Merged

[3.17] 3.17.7 backports 1 #45590

merged 18 commits into from
Jan 15, 2025

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jan 14, 2025

Please don't merge, I will merge it myself.

dmlloyd and others added 18 commits January 14, 2025 20:11
(cherry picked from commit c7f68ae)
…tion

The Vert.x Redis client does not always report the database instance number,
because sometimes, it simply isn't known. Specifically, that occurs when
the connection is tainted; for example, when a custom database is selected
using the `SELECT` command.

In this case, the trace simply will not include the dabatase instance number.

(cherry picked from commit 5589020)
`yq` is already included in the GitHub runners, so no need to install it

(cherry picked from commit d0101d0)
Signed-off-by: Michael Edgar <michael@xlate.io>
(cherry picked from commit cc15f64)
…rties artifact is met first

(cherry picked from commit 3e7ebdf)
Prior to this change, the health checks would
erroneously report the connection was up
if the database had yet to be contacted
by the application

(cherry picked from commit 289cf09)
This is related to quarkusio#45122 and reduce the amount of copy of the content
we keep in memory.

(cherry picked from commit 09edb56)
We would generate class proxies for each class even if we already
generated one, which is counter productive.
Introduce a cache to avoid that and make things a bit more efficient.

(cherry picked from commit 4feaf0f)
…in the Oracle JDBC extension"

This reverts commit 19d9ed1.

(cherry picked from commit 134637c)
```
- Adjust JDBC resource leak logging to use debug level instead of warnings for better log granularity.
- Enhance developer experience by reducing noise in application logs.
```

(cherry picked from commit 81a7c4b)
@gsmet gsmet added the area/infra internal and infrastructure related issues label Jan 14, 2025
@gsmet gsmet self-assigned this Jan 14, 2025
@quarkus-bot quarkus-bot bot changed the title 3.17.7 backports 1 [3.17] 3.17.7 backports 1 Jan 14, 2025
Copy link

quarkus-bot bot commented Jan 14, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/agroal area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/jdbc Issues related to the JDBC extensions area/logging labels Jan 14, 2025
@quarkus-bot quarkus-bot bot added area/maven area/mongodb area/platform Issues related to definition and interaction with Quarkus Platform area/rest area/security area/tracing area/vertx labels Jan 14, 2025
Copy link

github-actions bot commented Jan 14, 2025

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Jan 14, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit ee16cd1.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Jan 15, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ee16cd1.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ Devtools Tests - JDK 17 Logs Raw logs 🔍
Devtools Tests - JDK 21 Build Failures Logs Raw logs 🔍
✔️ Devtools Tests - JDK 17 Windows Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ Devtools Tests - JDK 21 #

- Failing: integration-tests/devtools 

📦 integration-tests/devtools

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka line 44 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
[Run project return status is zero] 
expected: 0
 but was: 1
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
	at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka(ReactiveMessagingCodestartIT.java:44)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka line 44 - History - More details - Source on GitHub

org.opentest4j.AssertionFailedError: 
[Run project return status is zero] 
expected: 0
 but was: 1
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildProject(QuarkusCodestartTest.java:158)
	at io.quarkus.devtools.testing.codestarts.QuarkusCodestartTest.buildAllProjects(QuarkusCodestartTest.java:145)
	at io.quarkus.devtools.codestarts.quarkus.ReactiveMessagingCodestartIT.buildKafka(ReactiveMessagingCodestartIT.java:44)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

📦 integration-tests/devtools/target/quarkus-codestart-test/quarkus-messaging-kafka-94e21dbf-84a4-4fe8-b97d-a89eda15aaea/real-data/java

ilove.quark.us.MyMessagingApplicationTest.test - History - More details - Source on GitHub

java.lang.RuntimeException: 
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor#startKafkaDevService threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerFetchException: Can't get Docker image: RemoteDockerImage(imageName=docker.io/redpandadata/redpanda:v24.1.2, imagePullPolicy=DefaultPullPolicy(), imageNameSubstitutor=org.testcontainers.utility.ImageNameSubstitutor$LogWrappedImageNameSubstitutor@4bc68639)
	at io.quarkus.kafka.client.deployment.DevServicesKafkaProcessor.startKafkaDevService(DevServicesKafkaProcessor.java:105)
	at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:733)
	at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:856)
	at io.quarkus.builder.BuildContext.run(BuildContext.java:256)
	at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:...

@gsmet gsmet merged commit e632ab6 into quarkusio:3.17 Jan 15, 2025
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agroal area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/docstyle issues related for manual docstyle review area/documentation area/infra internal and infrastructure related issues area/jdbc Issues related to the JDBC extensions area/logging area/maven area/mongodb area/platform Issues related to definition and interaction with Quarkus Platform area/rest area/security area/tracing area/vertx
Projects
None yet
Development

Successfully merging this pull request may close these issues.