Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update security-getting-started-tutorial from QE feedback #45686

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Jan 17, 2025

Update security-getting-started-tutorial from QE feedback.

Copy link

quarkus-bot bot commented Jan 17, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jan 17, 2025
@rolfedh rolfedh requested a review from sberyozkin January 17, 2025 16:36
@rolfedh rolfedh changed the title Update security-getting-started-tutorial from QE feedback WIP Update security-getting-started-tutorial from QE feedback Jan 17, 2025
@rolfedh rolfedh marked this pull request as draft January 17, 2025 16:37
@sberyozkin
Copy link
Member

I'm not sure we need to add file path locations, users do no create those files manually, making sure the directory structure matches the package name, they put it into IDE and IDE creates everything for them.

Copy link

github-actions bot commented Jan 17, 2025

🙈 The PR is closed and the preview is expired.

@rolfedh rolfedh marked this pull request as ready for review January 20, 2025 16:46
@rolfedh rolfedh force-pushed the 1033-update-gsw-security branch from c345864 to 8d3e117 Compare January 20, 2025 16:46
@rolfedh
Copy link
Contributor Author

rolfedh commented Jan 20, 2025

I'm not sure we need to add file path locations, users do no create those files manually, making sure the directory structure matches the package name, they put it into IDE and IDE creates everything for them.

Thanks, Sergey! While IDEs handle directory structures for most users, including file paths in code block labels adds clarity, reassures alignment with expectations, and helps those troubleshooting or using less automated setups. I appreciate the discussion!

@rolfedh rolfedh requested review from jedla97 and sberyozkin January 20, 2025 16:51

This comment has been minimized.

@rolfedh rolfedh changed the title WIP Update security-getting-started-tutorial from QE feedback Update security-getting-started-tutorial from QE feedback Jan 20, 2025
@rolfedh rolfedh requested a review from jedla97 January 20, 2025 19:40

This comment has been minimized.

@sberyozkin
Copy link
Member

@rolfedh Hi, looks like you need to recreate this PR since it contains a merge commit

@rolfedh rolfedh force-pushed the 1033-update-gsw-security branch from 81c2807 to b15f1ad Compare January 21, 2025 12:59
@rolfedh
Copy link
Contributor Author

rolfedh commented Jan 21, 2025

@rolfedh Hi, looks like you need to recreate this PR since it contains a merge commit

Sorry about that. Rebased and -f pushed with just one commit now. Thanks.

Copy link

quarkus-bot bot commented Jan 21, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b15f1ad.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin sberyozkin merged commit 1fcb77a into quarkusio:main Jan 21, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants