Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code format and missing dep on "writing a dev service" page #45703

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Fix code format and missing dep on "writing a dev service" page #45703

merged 1 commit into from
Feb 11, 2025
+73 −43

Conversation

ibethus
Copy link
Contributor

@ibethus ibethus commented Jan 19, 2025 •
edited by geoand
Loading

  • Fix code formatting in code blocks
  • Add a section about the required dependency for writing a dev service

Any comment is welcome 😃

@quarkus-bot quarkus-bot

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2025 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@ibethus ibethus force-pushed the fix-doc-writing-dev-service branch 3 times, most recently from b455c92 to e8728fe Compare January 19, 2025 16:51
@ibethus ibethus changed the title doc : fix code format and missing dep on "writing a dev service" page Fix code format and missing dep on "writing a dev service" page Jan 19, 2025
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@geoand geoand requested a review from holly-cummins January 20, 2025 08:42
holly-cummins
holly-cummins approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@holly-cummins holly-cummins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

gsmet
gsmet requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I added a few suggestions. The first one for sure requires a fix.

docs/src/main/asciidoc/extension-writing-dev-service.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-writing-dev-service.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-writing-dev-service.adoc Show resolved Hide resolved
docs/src/main/asciidoc/extension-writing-dev-service.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/extension-writing-dev-service.adoc Outdated Show resolved Hide resolved
@ibethus ibethus force-pushed the fix-doc-writing-dev-service branch from e4a5375 to da7fb63 Compare January 28, 2025 20:22
@ibethus
Copy link
Contributor Author

ibethus commented Jan 28, 2025

@gsmet changes have been made, open for review ✌️

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@ibethus ibethus force-pushed the fix-doc-writing-dev-service branch from da7fb63 to 88d94d7 Compare February 9, 2025 13:12
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
gsmet
gsmet approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will squash and merge once CI is green.

@ibethus @gsmet
doc : fix code format and missing dep
fc70d27 
* Fix code formating in code blocks
* Add a section about the required dependency for writing a dev service
@gsmet gsmet force-pushed the fix-doc-writing-dev-service branch from 88d94d7 to fc70d27 Compare February 11, 2025 12:54
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 11, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 11, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit fc70d27.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit d4f441b into quarkusio:main Feb 11, 2025
5 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 11, 2025
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 11, 2025
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Feb 11, 2025
@gsmet
Copy link
Member

gsmet commented Feb 11, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@holly-cummins holly-cummins holly-cummins approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement New feature or request
Projects
None yet
Milestone
3.19.0.CR1
Development

Successfully merging this pull request may close these issues.

Code format broken on page "Writing a Dev Service"
3 participants
@ibethus @gsmet @holly-cummins