Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for connecting to multiple devservice databases #45801

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

albers
Copy link
Contributor

@albers albers commented Jan 22, 2025

I had some difficulties connecting to the devservices databases of a service with multiple datasources because the documentation in the Dev Services for Databases guide is wrong.

How to verify

Inspect the devservice database containers of a multi-datasource application with docker inspect.

Here are the env vars of the postgres container for the named datasource "db1":

$ docker container inspect unruffled_franklin --format '{{json .Config.Env}}' | jq -r '.[]' | grep POSTGRES
POSTGRES_USER=quarkus
POSTGRES_PASSWORD=quarkus
POSTGRES_DB=db1

For reference, these are the corresponding env vars from a devservices container for the default database in a single-datasource setup:

$ docker container inspect clever_murdock --format '{{json .Config.Env}}' | jq -r '.[]' | grep POSTGRES
POSTGRES_USER=quarkus
POSTGRES_PASSWORD=quarkus
POSTGRES_DB=quarkus

This PR fixes the issue.

Signed-off-by: Harald Albers <github@albersweb.de>
Copy link

github-actions bot commented Jan 22, 2025

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Jan 22, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 6a63d8b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, good catch!

@gsmet gsmet merged commit 207387c into quarkusio:main Jan 24, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 24, 2025
@albers albers deleted the docs-multiple-devservice-dbs branch January 24, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants