Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable kubernetes-service-binding testing on Windows #45890

Merged

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Jan 27, 2025

It uses symlinks and they are complex to allow on Windows. Let's not ask our users to go do crazy things to test this particular module.

Fixes #45860
Related to #42756

It uses symlinks and they are complex to allow on Windows. Let's not ask
our users to go do crazy things to test this particular module.

Fixes quarkusio#45860
Related to quarkusio#42756
Copy link

🎊 PR Preview 8d65dcf has been successfully built and deployed to https://quarkus-pr-main-45890-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@Postremus
Copy link
Member

Postremus commented Jan 27, 2025

@gsmet works on my machine, thanks
I disabled the symlink support in gpedit, restart. -> works
Setting git config core.symlinks false, deleting src/test/resources/k8s/test-k8s/.hidden-symlink-dir and git restoring it (so it is not a symlink anymore) -> works

@gsmet gsmet marked this pull request as ready for review January 27, 2025 17:51
@gsmet
Copy link
Member Author

gsmet commented Jan 27, 2025

@famod hey. Do you have an explanation as to why GIB determines that there are so many impacted modules? This change should have affected only a few?

@famod
Copy link
Member

famod commented Jan 27, 2025

@famod hey. Do you have an explanation as to why GIB determines that there are so many impacted modules? This change should have affected only a few?

Hi @gsmet!
Since there is no exclusion for CONTRIBUTING.md I suppose GIB is matching this change to the root project/pom (quarkus-project) and so almost everything is built.

Copy link

quarkus-bot bot commented Jan 27, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1e826ea.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.MetricsTest.directCounterTest - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.MetricsTest.directCounterTest(MetricsTest.java:57)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ JVM Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.MetricsTest.directCounterTest - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.MetricsTest.directCounterTest(MetricsTest.java:57)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

io.quarkus.gradle.devmode.CompileOnlyDependencyDevModeTest.main - History

  • Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 2 minutes.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:164)

@gsmet gsmet merged commit eba4923 into quarkusio:main Jan 28, 2025
70 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 28, 2025
gsmet added a commit to gsmet/quarkus that referenced this pull request Jan 28, 2025
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.1 Jan 28, 2025
carlesarnal pushed a commit to carlesarnal/quarkus that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus main build fails on windows
4 participants