Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the Config from the TCCL when setting the Quarkus config #45926

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Jan 28, 2025

This should prevent failures like:
#45829 (comment)

The failure means that something or someone is registering the Config outside Quarkus, which is a bug we must also fix.

@gsmet
Copy link
Member

gsmet commented Jan 28, 2025

@radcortez, I think this is creating some config confusion:

2025-01-28 16:39:00,816 INFO  [io.quarkus] (Quarkus Main Thread) quarkus-vertx-http-deployment 999-SNAPSHOT on JVM (powered by Quarkus 999-SNAPSHOT) started in 2.918s. Listening on: http://localhost:8080
2025-01-28 16:39:00,819 INFO  [io.quarkus] (Quarkus Main Thread) Profile dev activated. Live Coding activated.
2025-01-28 16:39:00,819 INFO  [io.quarkus] (Quarkus Main Thread) Installed features: [cdi, security, smallrye-context-propagation, vertx]
2025-01-28 16:39:04,033 INFO  [io.quarkus] (Quarkus Main Thread) quarkus-vertx-http-deployment stopped in 0.007s
Error:  Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 9.100 s <<< FAILURE! -- in io.quarkus.devui.BuildMetricsTest
Error:  io.quarkus.devui.BuildMetricsTest.testGetBuildStepsMetrics -- Time elapsed: 8.933 s <<< ERROR!
java.lang.IllegalStateException: Request failed: Connection refused: localhost/127.0.0.1:8081
	at io.quarkus.devui.tests.DevUIJsonRPCTest$WebSocketResponse.message(DevUIJsonRPCTest.java:254)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:155)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:167)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.objectResultFromJsonRPC(DevUIJsonRPCTest.java:148)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.getJsonRPCResponse(DevUIJsonRPCTest.java:124)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.getJsonRPCResponse(DevUIJsonRPCTest.java:119)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.executeJsonRPCMethod(DevUIJsonRPCTest.java:86)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.executeJsonRPCMethod(DevUIJsonRPCTest.java:75)
	at io.quarkus.devui.tests.DevUIJsonRPCTest.executeJsonRPCMethod(DevUIJsonRPCTest.java:71)
	at io.quarkus.devui.BuildMetricsTest.testGetBuildStepsMetrics(BuildMetricsTest.java:23)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: io.netty.channel.AbstractChannel$AnnotatedConnectException: Connection refused: localhost/127.0.0.1:8081
Caused by: java.net.ConnectException: Connection refused
	at java.base/sun.nio.ch.Net.pollConnect(Native Method)
	at java.base/sun.nio.ch.Net.pollConnectNow(Net.java:672)
	at java.base/sun.nio.ch.SocketChannelImpl.finishConnect(SocketChannelImpl.java:946)
	at io.netty.channel.socket.nio.NioSocketChannel.doFinishConnect(NioSocketChannel.java:336)
	at io.netty.channel.nio.AbstractNioChannel$AbstractNioUnsafe.finishConnect(AbstractNioChannel.java:339)
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:776)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562)
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:840)

The server is started on port 8080 but the tests try to connect on 8081.

This comment has been minimized.

@radcortez
Copy link
Member Author

Interesting... maybe I did it a way that assumes that you wouldn't need that :)

I'll have a look.

@radcortez radcortez force-pushed the quarkus-config-factory branch from a5162e0 to c0af390 Compare January 29, 2025 12:40
Copy link

quarkus-bot bot commented Jan 29, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c0af390.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 integration-tests/opentelemetry

io.quarkus.it.opentelemetry.MetricsTest.directCounterTest - History

  • Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.MetricsTest.directCounterTest(MetricsTest.java:57)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

@gsmet gsmet merged commit 6a87ab6 into quarkusio:main Jan 29, 2025
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Jan 29, 2025
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.2 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants