Be more defensive about sources Path in integration tests

[geoand]

• Fixes: Native tests fail in Gradle-based Quarkus project when module has no classes in src/main/java #45933

[geoand]

@aloubyansky does this make sense, or do we need something that is lower level?

[aloubyansky]

It feels like the API should expose proper application roots that exist.

[geoand]

Yeah, that's why I asked

[aloubyansky]

We should check what happens for an equivalent Maven project

[geoand]

Right, I'll look into this a little more, as it's probably a test specific issue

[geoand]

PR updated. It fixes the original issue

[aloubyansky]

Interesting, looks like it's due to allowing it here https://github.com/quarkusio/quarkus/blob/main/test-framework/common/src/main/java/io/quarkus/test/common/PathTestHelper.java#L220

[aloubyansky]

Given the above, the fix seems to make sense.

[aloubyansky]

Although this API should probably be reviewed and reflect better what it actually does. getAppClassLocationForTestLocation returning a non-existing location looks weird.

[geoand]

Although this API should probably be reviewed and reflect better what it actually does. getAppClassLocationForTestLocation returning a non-existing location looks weird.

Indeed, it's pretty hacky...

[gsmet]

Yeah, while I'm all for including this PR, I really think we shouldn't propagate Paths that don't exist.

[aloubyansky]

Ideally, ApplicationModel should be used to get all the paths instead of best-guessing. This is something to look into.

[geoand]

Any pointers on how to obtain it from here?

[aloubyansky]

I don't think it'd be a quick fix. This is something to figure out.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1088455.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/grpc-hibernate

✖ com.example.grpc.hibernate.VertxBlockingRawTest.shouldAdd - History

• Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.MetricsTest.directCounterTest - History

• Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.MetricsTest.directCounterTest(MetricsTest.java:57)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

---

⚙️ JVM Tests - JDK 21

📦 integration-tests/opentelemetry

✖ io.quarkus.it.opentelemetry.MetricsTest.directCounterTest - History

• Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds. - org.awaitility.core.ConditionTimeoutException

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.it.opentelemetry.MetricsTest was not fulfilled within 5 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.it.opentelemetry.MetricsTest.directCounterTest(MetricsTest.java:57)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)

[geoand]

I don't think it'd be a quick fix. This is something to figure out.

Understood, thanks!