-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to UBI 9 by default #45973
Switch to UBI 9 by default #45973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo.
...age-jib/deployment/src/main/java/io/quarkus/container/image/jib/deployment/JibProcessor.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've mentioned this elsewhere but if any of the Quarkus container files use |
@jerboaa Thanks, at the very least, this will need to be added to the migration guide. |
This comment has been minimized.
This comment has been minimized.
Some of the failures are definitely related. Also about @jerboaa's note, I've added it to the epic (so we won't forget) |
This comment has been minimized.
This comment has been minimized.
On Hold - See quarkusio/quarkus-images#286. We cannot update the builder image. It should not affect this PR, but there are a few mysteries to understand. One of them is:
Even with no changes, I cannot execute my container on my Mac anymore. I needed to change my Dockerfile to add more permissions. I need to make sure our current setup works before merging this. |
This comment has been minimized.
This comment has been minimized.
81fdf2b
to
be87c80
Compare
This comment has been minimized.
This comment has been minimized.
be87c80
to
3451f2e
Compare
3451f2e
to
8721003
Compare
Related to #45968 At the moment we have:
What's missing is the JAVA_OPTS change |
This comment has been minimized.
This comment has been minimized.
@cescoffier I just rebased because one of my PRs conflicted with this one. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
edf2c57
to
a025aa0
Compare
a025aa0
to
299db8d
Compare
This comment has been minimized.
This comment has been minimized.
This is hopefully ready. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good overall but I added two questions.
...ork/junit5/src/main/java/io/quarkus/test/junit/launcher/DockerContainerLauncherProvider.java
Outdated
Show resolved
Hide resolved
integration-tests/container-image/maven-invoker-way/src/it/container-native-main/pom.xml
Outdated
Show resolved
Hide resolved
- Update UBI 8 and UBI 9 versions (including OpenJDK images) - Switch the default to UBI 9 This commit does not cover the builder images and the quarkus-micro images as they are not yet available using UBI9.
299db8d
to
317fab5
Compare
Status for workflow
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Status for workflow
|
@cescoffier we need an entry in the migration guide for this one! |
@gsmet Done - I had a draft ready. |
This commit does not cover the builder images and the quarkus-micro images, as they are not yet available using UBI9.Fix #45968.