Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to UBI 9 by default #45973

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Jan 30, 2025

  • Update UBI 8 and UBI 9 versions (including OpenJDK images)
  • Switch the default to UBI 9

This commit does not cover the builder images and the quarkus-micro images, as they are not yet available using UBI9.

Fix #45968.

@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/graphics area/kubernetes area/maven area/platform Issues related to definition and interaction with Quarkus Platform labels Jan 30, 2025
Copy link

quarkus-bot bot commented Jan 30, 2025

/cc @Karm (awt), @galderz (awt)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

github-actions bot commented Jan 30, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 30, 2025
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo.

This comment has been minimized.

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerboaa
Copy link
Contributor

jerboaa commented Jan 30, 2025

I've mentioned this elsewhere but if any of the Quarkus container files use JAVA_OPTIONS environment variable from the OpenJDK images, this variable is gone with UBI9. Replaced by JAVA_OPTS, preferred migration env would be JAVA_OPTS_APPEND.

@gsmet
Copy link
Member

gsmet commented Jan 30, 2025

@jerboaa Thanks, at the very least, this will need to be added to the migration guide.

This comment has been minimized.

@cescoffier
Copy link
Member Author

Some of the failures are definitely related.

Also about @jerboaa's note, I've added it to the epic (so we won't forget)

This comment has been minimized.

@cescoffier
Copy link
Member Author

On Hold - See quarkusio/quarkus-images#286. We cannot update the builder image. It should not affect this PR, but there are a few mysteries to understand.

One of them is:

Error: preparing container 72ea63962af25eacc70e94f256ebd468df6e4067ce8bbf3078cf1d50a96775e2 for attach: crun: open executable: Permission denied: OCI permission denied

Even with no changes, I cannot execute my container on my Mac anymore. I needed to change my Dockerfile to add more permissions. I need to make sure our current setup works before merging this.

This comment has been minimized.

This comment has been minimized.

@quarkus-bot quarkus-bot bot added area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/testing labels Feb 4, 2025
@cescoffier
Copy link
Member Author

Related to #45968

At the moment we have:

  • runtime images are now using UBI 9 (both JVM, native, and micro)
  • builder images are now using UBI 9 (GraalVM and Mandrel)
  • documentation is updated (as well as the template) to indicate how to switch back to UBI 8 builder images

What's missing is the JAVA_OPTS change

This comment has been minimized.

@gsmet
Copy link
Member

gsmet commented Feb 4, 2025

@cescoffier I just rebased because one of my PRs conflicted with this one.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@cescoffier
Copy link
Member Author

This is hopefully ready.

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall but I added two questions.

- Update UBI 8 and UBI 9 versions (including OpenJDK images)
- Switch the default to UBI 9

This commit does not cover the builder images and the quarkus-micro images as they are not yet available using UBI9.
Copy link

quarkus-bot bot commented Feb 5, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 317fab5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

quarkus-bot bot commented Feb 6, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 317fab5.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod_AsyncFailed(MicrometerTimedInterceptorTest.java:150)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)

📦 integration-tests/grpc-hibernate

com.example.grpc.hibernate.VertxBlockingRawTest.shouldAdd - History

  • Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in com.example.grpc.hibernate.BlockingRawTestBase was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at com.example.grpc.hibernate.BlockingRawTestBase.shouldAdd(BlockingRawTestBase.java:59)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)

@cescoffier cescoffier merged commit e54fdeb into quarkusio:main Feb 6, 2025
55 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 6, 2025
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 6, 2025
@gsmet
Copy link
Member

gsmet commented Feb 10, 2025

@cescoffier we need an entry in the migration guide for this one!

@cescoffier
Copy link
Member Author

@gsmet Done - I had a draft ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/gradle Gradle area/graphics area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kubernetes area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/testing release/noteworthy-feature triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to UBI 9
6 participants