Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote address to gRPC spans #45976

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

brunobat
Copy link
Contributor

@brunobat brunobat commented Jan 30, 2025

This data was missing from spans and a user asked for it.

Copy link

quarkus-bot bot commented Jan 30, 2025

/cc @radcortez (opentelemetry)

@brunobat brunobat requested a review from alesj January 30, 2025 11:02
@brunobat brunobat self-assigned this Jan 30, 2025
Copy link

quarkus-bot bot commented Jan 30, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5d0ed38.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 integration-tests/reactive-messaging-context-propagation

io.quarkus.it.kafka.KafkaContextPropagationTest.testAbsenceOfContextPropagationBlocking - History

  • 1 expectation failed. Expected status code <500> but was <204>. - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Expected status code <500> but was <204>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

io.quarkus.it.kafka.KafkaContextPropagationTest.testAbsenceOfContextPropagationBlockingUni - History

  • 1 expectation failed. Expected status code <500> but was <204>. - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Expected status code <500> but was <204>.

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)

⚙️ JVM Tests - JDK 21

📦 integration-tests/reactive-messaging-context-propagation

io.quarkus.it.kafka.KafkaContextPropagationTest.testAbsenceOfContextPropagationBlocking - History

  • 1 expectation failed. Expected status code <500> but was <204>. - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Expected status code <500> but was <204>.

	at java.base/jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(DirectConstructorHandleAccessor.java:62)
	at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:502)
	at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:486)
	at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)

@gsmet
Copy link
Member

gsmet commented Jan 30, 2025

I'm not against backporting to 3.18 if you think it makes sense. Add the label if you do.

@gastaldi
Copy link
Contributor

Waiting for @alesj's approval before merging this

@gastaldi gastaldi merged commit fb68b92 into quarkusio:main Feb 1, 2025
29 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 1, 2025
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.2 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants