Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute: fix template global class generation in the dev mode #2 #46014

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Qute: fix template global class generation in the dev mode #2 #46014

merged 1 commit into from
Feb 6, 2025
+35 −13

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 31, 2025

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 31, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added the area/qute The template engine label Jan 31, 2025
@mkouba
Copy link
Contributor Author

mkouba commented Jan 31, 2025

@gbourant it would be great if you could test this fix as well.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 31, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d85129e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gbourant
Copy link

gbourant commented Jan 31, 2025 •
edited
Loading

Thank you @mkouba, i tested your fix and now it's working.

@mkouba mkouba requested a review from gastaldi January 31, 2025 20:02
gastaldi
gastaldi reviewed Feb 1, 2025
View reviewed changes
extensions/qute/deployment/src/main/java/io/quarkus/qute/deployment/QuteDevModeProcessor.java
@@ -53,7 +53,7 @@ public boolean test(String t) {
return false;
}
});
try (ClassCreator classCreator = ClassCreator.builder().className("io.quarkus.qute.test.QuteDummyGlobals")
try (ClassCreator classCreator = ClassCreator.builder().className("org.acme.qute.test.QuteDummyGlobals")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing this package name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is a bit odd.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why changing this package name?

Because we need to simulate an ordering issue where the generated globals are sorted by the FQCN of the declaring class.

@mkouba mkouba merged commit ec343c7 into quarkusio:main Feb 6, 2025
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 6, 2025
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.3 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/qute The template engine kind/bugfix triage/backport-3.15
Projects
None yet
Milestone
3.18.3
Development

Successfully merging this pull request may close these issues.

Qute TemplateGlobal throws error on live reload
4 participants
@mkouba @gbourant @gastaldi @gsmet