opentracing: Update to the instructions to reflect that agent (via UDP) can now be used #4603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P) can now be used Signed-off-by: Gary Brown <gary@brownuk.com>
gsmet
changed the title
gsmet
approved these changes
Oct 16, 2019
There was a problem hiding this comment.
Looks good to me thanks. Can you update the quickstart accordingly if it's needed? https://github.com/quarkusio/quarkus-quickstarts/tree/development/using-opentracing
|
@gsmet I've tested the instructions in the quickstart - but one question I was going to ask - the quickstart has been updated to include a chain request (aswell as the hello request) - which results in a call out back to the hello endpoint. So it provides a slightly more complex trace. I think the guide is fine just showing how to create a simpler example - but was wondering whether we should refer to the existing example as including the additional endpoint, and how to run it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…P) can now be used
Signed-off-by: Gary Brown gary@brownuk.com