Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and restore hibernate-reactive-mssql tests #46043

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Feb 3, 2025

Fixes #46018

(thanks again @holly-cummins for spotting this...)

I had to make a few changes to the tests, which were quite thoroughly broken. Not even compiling.

Even though we went (quite) some time without running these tests, it looks like we got lucky: tests still pass, and (critically) native compilation works fine.

I'd recommend trying to backport to (at least) 3.15 to make sure things are alright there too...

@yrodiere yrodiere changed the title It mssql fix Fix and restore hibernate-reactive-mssql tests Feb 3, 2025
@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Feb 3, 2025
In particular:

* Remove undertow, whose dependency was not correctly set, and which
  shouldn't be used regardless (see
  18d1034)
* Fix SQL syntax to use SQL-Server specific parameter placeholders;
  see https://quarkus.io/guides/reactive-sql-clients#reactive-sql-clients-details
* Fix configuration/setup to mention mssql instead of mysql...

Hibernate Reactive MS
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and good catch @holly-cummins !

Copy link

quarkus-bot bot commented Feb 3, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e1f94a9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/scheduler/deployment

io.quarkus.scheduler.test.timezone.ScheduledMethodTimeZoneTest.testScheduledJobs - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.scheduler.test.timezone.ScheduledMethodTimeZoneTest.testScheduledJobs(ScheduledMethodTimeZoneTest.java:70)

@gsmet gsmet merged commit ee30de5 into quarkusio:main Feb 3, 2025
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 3, 2025
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.2 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure triage/backport-3.15 triage/flaky-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integration-tests/hibernate-reactive-mssql is not being run (and does not build)
2 participants