Recalculate config property names during tests #46044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #42715, the Config is initialized way earlier, which means that if the System source is mutated, the list of property names is not updated because it is cached.
Our assumption is that the Config is immutable, but we have these workarounds to pass the configuration around. Ideally, we shouldn't be mutating the configuration, which causes issues like:
Obviously, it is tricky to make that change now, and we are still trying to figure out how to handle the case of the port, but the goal is to completely remove the mutability of sources.
For now, I added a way to refresh the list of property names. Probably, a better way is to add some way to not cache the list of names for specific profiles, but that requires changes in SR Config, while this one can be done directly in Quarkus. I'll keep this in mind.