Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recalculate config property names during tests #46044

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Feb 3, 2025

With #42715, the Config is initialized way earlier, which means that if the System source is mutated, the list of property names is not updated because it is cached.

Our assumption is that the Config is immutable, but we have these workarounds to pass the configuration around. Ideally, we shouldn't be mutating the configuration, which causes issues like:

Obviously, it is tricky to make that change now, and we are still trying to figure out how to handle the case of the port, but the goal is to completely remove the mutability of sources.

For now, I added a way to refresh the list of property names. Probably, a better way is to add some way to not cache the list of names for specific profiles, but that requires changes in SR Config, while this one can be done directly in Quarkus. I'll keep this in mind.

Copy link

quarkus-bot bot commented Feb 3, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a1cf7a0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit a31cdfc into quarkusio:main Feb 4, 2025
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 4, 2025
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.2 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuarkusIntegrationTest: publishing a random port in the started container no longer works
3 participants