Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetryLogHandler - Do not read config for each publish #46099

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 5, 2025

This is definitely suboptimal and can lead to infinite loops (if some logging is done in the config layer).

Also made some other micro improvements.

This is definitely suboptimal and can lead to infinite loops.

Also made some other micro improvements.
@gsmet gsmet requested a review from brunobat February 5, 2025 14:05
Copy link

quarkus-bot bot commented Feb 5, 2025

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@brunobat
Copy link
Contributor

brunobat commented Feb 5, 2025

Related to #46095

Copy link

quarkus-bot bot commented Feb 5, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 80e4bc6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.binder.VertxTcpMetricsTest.testTcpMetrics - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:934)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:353)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:346)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:836)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:827)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:817)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

@brunobat brunobat merged commit 3e26882 into quarkusio:main Feb 5, 2025
29 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 5, 2025
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.3 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants