Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Vert.x Mutiny bindings 3.18.1 #46115

Merged

Conversation

jponge
Copy link
Member

@jponge jponge commented Feb 5, 2025

Bump to Vert.x Mutiny bindings 3.18.1

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/mutiny area/smallrye area/vertx labels Feb 5, 2025
@gsmet
Copy link
Member

gsmet commented Feb 5, 2025

Could you explain how updating the bindings fixes an issue in the Vert.x SQL client?

@jponge jponge force-pushed the deps/mutiny-vertx-bindings-3.18.1-vertx-4.5.12 branch from 423f75a to d8e18cc Compare February 5, 2025 22:39
@jponge
Copy link
Member Author

jponge commented Feb 5, 2025

You're right, I initially went to do this because fixing that issue required a Vert.x bump but it was already in main. It just stuck to my mind that it would also fix it...

Copy link

quarkus-bot bot commented Feb 6, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d8e18cc.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.logs.LoggingFrameworkTest.testLog4jLogging - History

  • Expected log to have body <ValueString{Log4j Logging message}> but was <ValueString{RESTEASY004687: Closing a class org.jboss.resteasy.client.jaxrs.engines.ManualClosingApacheHttpClient43Engine$CleanupAction instance for you. Please close clients yourself.}> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: Expected log to have body <ValueString{Log4j Logging message}> but was <ValueString{RESTEASY004687: Closing a class org.jboss.resteasy.client.jaxrs.engines.ManualClosingApacheHttpClient43Engine$CleanupAction instance for you. Please close clients yourself.}>
	at io.quarkus.opentelemetry.deployment.logs.LoggingFrameworkTest.testLog4jLogging(LoggingFrameworkTest.java:95)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.logs.LoggingFrameworkTest.testJulLogging - History

  • Expected log to have body <ValueString{JUL Logging message}> but was <ValueString{RESTEASY004687: Closing a class org.jboss.resteasy.client.jaxrs.engines.ManualClosingApacheHttpClient43Engine$CleanupAction instance for you. Please close clients yourself.}> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: Expected log to have body <ValueString{JUL Logging message}> but was <ValueString{RESTEASY004687: Closing a class org.jboss.resteasy.client.jaxrs.engines.ManualClosingApacheHttpClient43Engine$CleanupAction instance for you. Please close clients yourself.}>
	at io.quarkus.opentelemetry.deployment.logs.LoggingFrameworkTest.testJulLogging(LoggingFrameworkTest.java:109)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@gsmet gsmet merged commit ea2d7eb into quarkusio:main Feb 6, 2025
52 checks passed
@gsmet gsmet added this to the 3.18.3 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants