Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace outdated hostname v1 property for keycloak dev service in shared networks #46141

Merged

Conversation

HerrDerb
Copy link
Contributor

@HerrDerb HerrDerb commented Feb 7, 2025

#45793

Fix keycloak dev service for shared network use.
Remove deprecated and already removed hostname v1 property and configure according hostname v2.

TBD: Tests (quarkusIntTest -Dquarkus.container-image.build=true) to ensure functionality in future?

@HerrDerb HerrDerb changed the title Replace hostname v1 property for keycloak dev service in shared networks Replace outdated hostname v1 property for keycloak dev service in shared networks Feb 7, 2025
@sberyozkin
Copy link
Member

Thanks @HerrDerb, I've opened a dedicated issue to get the test restored

Copy link

quarkus-bot bot commented Feb 7, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d80e3a9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@sberyozkin sberyozkin self-requested a review February 7, 2025 18:01
@sberyozkin sberyozkin merged commit 2786932 into quarkusio:main Feb 7, 2025
26 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 7, 2025
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.3 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants