-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify and fix building the list of framework endpoints #46181
Conversation
We already have the full path at some point so there's really no need to rebuild it once again, especially since the code was incorrect as it was adding the /q/ prefix always if it wasn't there in the path. It's perfectly valid to not have /q in the path, for instance if you set quarkus.smallrye-health.root-path to /something/else. I added a new test based on the report in addition to the ones we added recently for related fixes. Fixes quarkusio#46040
/cc @brunobat (opentelemetry), @radcortez (opentelemetry) |
Note: we really need to clean up all this and come up with something more solid. Everything is extremely brittle. |
...ons/vertx-http/deployment/src/main/java/io/quarkus/vertx/http/deployment/RouteBuildItem.java
Show resolved
Hide resolved
...vertx-http/deployment/src/main/java/io/quarkus/vertx/http/deployment/VertxHttpProcessor.java
Show resolved
Hide resolved
Status for workflow
|
We already have the full path at some point so there's really no need to rebuild it once again, especially since the code was incorrect as it was adding the /q/ prefix always if it wasn't there in the path.
It's perfectly valid to not have /q in the path, for instance if you set quarkus.smallrye-health.root-path to /something/else.
I added a new test based on the report in addition to the ones we added recently for related fixes.
Fixes #46040