Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and fix building the list of framework endpoints #46181

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 10, 2025

We already have the full path at some point so there's really no need to rebuild it once again, especially since the code was incorrect as it was adding the /q/ prefix always if it wasn't there in the path.

It's perfectly valid to not have /q in the path, for instance if you set quarkus.smallrye-health.root-path to /something/else.

I added a new test based on the report in addition to the ones we added recently for related fixes.

Fixes #46040

We already have the full path at some point so there's really no need to
rebuild it once again, especially since the code was incorrect as it was
adding the /q/ prefix always if it wasn't there in the path.

It's perfectly valid to not have /q in the path, for instance if you set
quarkus.smallrye-health.root-path to /something/else.

I added a new test based on the report in addition to the ones we added
recently for related fixes.

Fixes quarkusio#46040
Copy link

quarkus-bot bot commented Feb 10, 2025

/cc @brunobat (opentelemetry), @radcortez (opentelemetry)

@gsmet
Copy link
Member Author

gsmet commented Feb 10, 2025

Note: we really need to clean up all this and come up with something more solid. Everything is extremely brittle.

Copy link

quarkus-bot bot commented Feb 10, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit d8daa71.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 21

📦 extensions/micrometer-opentelemetry/deployment

io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod - History

  • Stream has no elements - java.lang.IllegalArgumentException
java.lang.IllegalArgumentException: Stream has no elements
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
	at java.base/java.util.Optional.orElseThrow(Optional.java:403)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
	at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
	at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod(MicrometerTimedInterceptorTest.java:77)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.logs.LoggingFrameworkTest.testJulLogging - History

  • Expected log to have body <ValueString{JUL Logging message}> but was <ValueString{RESTEASY004687: Closing a class org.jboss.resteasy.client.jaxrs.engines.ManualClosingApacheHttpClient43Engine$CleanupAction instance for you. Please close clients yourself.}> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: Expected log to have body <ValueString{JUL Logging message}> but was <ValueString{RESTEASY004687: Closing a class org.jboss.resteasy.client.jaxrs.engines.ManualClosingApacheHttpClient43Engine$CleanupAction instance for you. Please close clients yourself.}>
	at io.quarkus.opentelemetry.deployment.logs.LoggingFrameworkTest.testJulLogging(LoggingFrameworkTest.java:109)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

📦 extensions/scheduler/deployment

io.quarkus.scheduler.test.timezone.ScheduledMethodTimeZoneTest.testScheduledJobs - History

  • expected: <true> but was: <false> - org.opentest4j.AssertionFailedError
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
	at io.quarkus.scheduler.test.timezone.ScheduledMethodTimeZoneTest.testScheduledJobs(ScheduledMethodTimeZoneTest.java:70)

@gsmet gsmet merged commit 85941d3 into quarkusio:main Feb 11, 2025
55 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 11, 2025
@gsmet gsmet modified the milestones: 3.19 - main, 3.18.3 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTelemetry extension traces health endpoints when a custom root-path is configured
3 participants