-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): propose a mapKey for generated config docs of a Map config item only for config group #4715
fix(docs): propose a mapKey for generated config docs of a Map config item only for config group #4715
Conversation
368ec55
to
872a66b
Compare
@machi1990 so I finally got to this one: I rebased and generated the doc but it doesn't work. There are several elements with the same anchor in the KeycloakPolicyEnforcerConfig. I wonder if it's not the two maps at the bottom causing issues. Could you have a look? |
Hi Guillaume, I think we the What we can try to detect this configuration and fallback to not treating the keys as passthrough - we'll have something like this Also, the description on the two config items could use some love. If we display the two keys just like suggested above with a proper description - what is the complex config or a simple config and when to use one or the other, an example usage will be useful. In the meantime we have empty java docs
WDYT ? @pedroigor @sberyozkin |
I hadn't followed this but you're right it looks very fishy. |
872a66b
to
91c5c9b
Compare
So... the config property is OK but... the type is not. In the MongoDB case I put in the original issue, you need the type to be |
91c5c9b
to
934a73b
Compare
934a73b
to
4f3cac6
Compare
@gsmet I just rebased with master. This one is ready for review now. |
4f3cac6
to
1413d0e
Compare
…r namedDataSources in AgroalBuildTimeConfig
1413d0e
to
4499400
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it fixes some very important issues with doc generation so let's merge it and backport it.
Thanks @machi1990 ! |
My pleasure :-) |
Fixes #4700
/cc @gsmet can you try this fix please? thanks.