Distinguish between Maven and Gradle for hint-text #4899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machi1990
requested changes
Oct 27, 2019
| } | ||
| else { | ||
| System.out.println("\nAdd an extension to your project by adding the dependency to your " + | ||
| "pom.xml or use `mvn quarkus:add-extension -Dextensions=\"artifactId\"`"); |
There was a problem hiding this comment.
Suggested change
| "pom.xml or use `mvn quarkus:add-extension -Dextensions=\"artifactId\"`"); | |
| "pom.xml or use `./mvnw quarkus:add-extension -Dextensions=\"artifactId\"`"); |
independent-projects/tools/common/src/main/java/io/quarkus/cli/commands/ListExtensions.java
Outdated
Show resolved
Hide resolved
|
CI failure looks unrelated, can you try to rebase to latest master and see if that fixes the issue. |
|
rebased to latest master and integrated your suggested changes |
Cool, let's see if CI is happy this time. Also, sorry to be nitpicking, can we also squash everything the two commits into one. |
machi1990
added
area/build
area/user-experience
|
Done! |
|
Can you please rebase on master to pick up a CI fix? |
gastaldi
reviewed
Oct 27, 2019
independent-projects/tools/common/src/main/java/io/quarkus/cli/commands/ListExtensions.java
Outdated
Show resolved
Hide resolved
gastaldi
reviewed
Oct 27, 2019
independent-projects/tools/common/src/main/java/io/quarkus/cli/commands/ListExtensions.java
Outdated
Show resolved
Hide resolved
gastaldi
added
the
triage/waiting-for-ci
stuartwdouglas
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4778