Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After failed start make sure to read the HTTP config with the correct TCCL #4950

Merged
merged 1 commit into from
Oct 29, 2019
Merged

After failed start make sure to read the HTTP config with the correct TCCL #4950

merged 1 commit into from
Oct 29, 2019

Conversation

stuartwdouglas
Copy link
Member

… TCCL

Fixes #4815

@stuartwdouglas stuartwdouglas mentioned this pull request Oct 28, 2019
Merged
@gsmet gsmet changed the title After failed start make sure to read the HTTP config with the correct… After failed start make sure to read the HTTP config with the correct TCCL Oct 28, 2019
@gsmet gsmet added this to the 0.27.0 milestone Oct 28, 2019
geoand
geoand approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the scenario I mentioned in #4934 was failing and with this PR it works

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 29, 2019
@stuartwdouglas stuartwdouglas merged commit 7312a80 into quarkusio:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

No hot reload on bad configuration wich block the quarkus startup and when http.port is overridden
3 participants
@stuartwdouglas @geoand @gsmet