Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Lambda - fix native, more docs #4951

Merged
merged 2 commits into from
Oct 30, 2019

Conversation

patriot1burke
Copy link
Contributor

  • Testing quarkus-amazon-lambda uncovered some native bugs that needed to be fixed
  • quarkus-amazon-lambda-http needed to set tmpdir for vertx web cache
  • Docs for quarkus-amazon-lambda
  • improved quarkus-amazon-lambda-http docs

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with the code so it's mostly a doc review sorry but I spotted a few things that needs fixing.

Could you take care of them and squash everything once done?

docs/src/main/asciidoc/amazon-lambda-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/amazon-lambda-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/amazon-lambda-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/amazon-lambda-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/amazon-lambda-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/amazon-lambda-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/amazon-lambda-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/amazon-lambda-guide.adoc Outdated Show resolved Hide resolved
fix pom

fix imports

Update docs/src/main/asciidoc/amazon-lambda-guide.adoc

Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>

Update docs/src/main/asciidoc/amazon-lambda-guide.adoc

Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>

Update docs/src/main/asciidoc/amazon-lambda-guide.adoc

Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>

Update docs/src/main/asciidoc/amazon-lambda-guide.adoc

Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>

Update docs/src/main/asciidoc/amazon-lambda-guide.adoc

Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>

Update docs/src/main/asciidoc/amazon-lambda-guide.adoc

Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>

Update docs/src/main/asciidoc/amazon-lambda-guide.adoc

Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com>

doc review changes
@stuartwdouglas stuartwdouglas merged commit d903bbb into quarkusio:master Oct 30, 2019
@stuartwdouglas stuartwdouglas added this to the 0.27.0 milestone Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants