-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Lambda - fix native, more docs #4951
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
patriot1burke
commented
Oct 28, 2019
- Testing quarkus-amazon-lambda uncovered some native bugs that needed to be fixed
- quarkus-amazon-lambda-http needed to set tmpdir for vertx web cache
- Docs for quarkus-amazon-lambda
- improved quarkus-amazon-lambda-http docs
patriot1burke
force-pushed
the
lambda
branch
2 times, most recently
from
October 29, 2019 16:49
e71011d
to
bf61be8
Compare
gsmet
requested changes
Oct 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with the code so it's mostly a doc review sorry but I spotted a few things that needs fixing.
Could you take care of them and squash everything once done?
...oyment/src/main/java/io/quarkus/amazon/lambda.http/deployment/AmazonLambdaHttpProcessor.java
Show resolved
Hide resolved
...mbda/deployment/src/main/java/io/quarkus/amazon/lambda/deployment/AmazonLambdaProcessor.java
Show resolved
Hide resolved
fix pom fix imports Update docs/src/main/asciidoc/amazon-lambda-guide.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update docs/src/main/asciidoc/amazon-lambda-guide.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update docs/src/main/asciidoc/amazon-lambda-guide.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update docs/src/main/asciidoc/amazon-lambda-guide.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update docs/src/main/asciidoc/amazon-lambda-guide.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update docs/src/main/asciidoc/amazon-lambda-guide.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> Update docs/src/main/asciidoc/amazon-lambda-guide.adoc Co-Authored-By: Guillaume Smet <guillaume.smet@gmail.com> doc review changes
stuartwdouglas
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.