Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure JDK 8 is used with Gradle #4962

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Ensure JDK 8 is used with Gradle #4962

merged 1 commit into from
Oct 29, 2019

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Oct 29, 2019

Fixes: #4823

@geoand geoand added this to the 0.27.0 milestone Oct 29, 2019
gastaldi
gastaldi reviewed Oct 29, 2019
View reviewed changes
...tform-descriptor-json/src/main/resources/templates/basic-rest/java/build.gradle-template.ftl
@@ -38,5 +38,9 @@ compileJava {
options.compilerArgs << '-parameters'
}

java {
sourceCompatibility = JavaVersion.VERSION_1_8
targetCompatibility = JavaVersion.VERSION_1_8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove the java {} and declare those two properties in the root (not sure how Gradle users do tbh)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what you describe is the old way of doing things, although I am not sure :)

@geoand geoand merged commit 0d1def3 into quarkusio:master Oct 29, 2019
@geoand geoand deleted the #4823 branch October 29, 2019 10:51
@ia3andy
Copy link
Contributor

ia3andy commented Oct 29, 2019

thanks @geoand and @gastaldi !!

@ia3andy
Copy link
Contributor

ia3andy commented Oct 29, 2019

I will test it this afternoon

@geoand
Copy link
Contributor Author

geoand commented Oct 29, 2019

@ia3andy if you encounter any problems, let me know immediately and I'll take care of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

@gastaldi gastaldi gastaldi approved these changes

@ia3andy ia3andy Awaiting requested review from ia3andy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

Gradle doesn't work if using JDK 11
4 participants
@geoand @ia3andy @gastaldi @aloubyansky