Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Platform Descriptor: load resources from a classloader instead of FileSystem #4971

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Platform Descriptor: load resources from a classloader instead of FileSystem #4971

merged 1 commit into from
Oct 29, 2019

Conversation

aloubyansky
Copy link
Member

Fixes #4959

Platform Descriptor: load resources from a classloader instead of usi…
f37ed16 
…ng FileSystem for a ZIP, this enables to use it in native mode
@aloubyansky aloubyansky added the area/platform Issues related to definition and interaction with Quarkus Platform label Oct 29, 2019
@aloubyansky aloubyansky added this to the 0.27.0 milestone Oct 29, 2019
ia3andy
ia3andy approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ia3andy
Copy link
Contributor

ia3andy commented Oct 29, 2019

@aloubyansky do u know why CI failed?

@aloubyansky
Copy link
Member Author

I don't see how it's related
2019-10-29T12:30:24.9929323Z [ERROR] asciidoctor: WARN: ed/config/quarkus-oidc.adoc: line 7: id assigned to anchor already in use: quarkus-oidc_configuration 2019-10-29T12:30:24.9931043Z [ERROR] asciidoctor: WARN: ed/config/quarkus-oidc.adoc: line 11: id assigned to anchor already in use: quarkus-oidc_quarkus.oidc.enabled 2019-10-29T12:30:24.9952650Z [ERROR] asciidoctor: WARN: ed/config/quarkus-oidc.adoc: line 20: id assigned to anchor already in use: quarkus-oidc_quarkus.oidc.auth-server-url 2019-10-29T12:30:24.9953970Z [ERROR] asciidoctor: WARN: ed/config/quarkus-oidc.adoc: line 29: id assigned to anchor already in use: quarkus-oidc_quarkus.oidc.introspection-path 2019-10-29T12:30:24.9965619Z [ERROR] asciidoctor: WARN: ed/config/quarkus-oidc.adoc: line 38: id assigned to anchor already in use: quarkus-oidc_quarkus.oidc.jwks-path 2019-10-29T12:30:24.9977457Z [ERROR] asciidoctor: WARN: ed/config/quarkus-oidc.adoc: line 47: id assigned to anchor already in use: quarkus-oidc_quarkus.oidc.public-key 2019-10-29T12:30:24.9978360Z [ERROR] asciidoctor: WARN: ed/config/quarkus-oidc.adoc: line 56: id assigned to anchor already in use: quarkus-oidc_quarkus.oidc.client-id 2019-10-29T12:30:24.9999427Z [ERROR] asciidoctor: WARN: ed/config/quarkus-oidc.adoc: line 65: id assigned to anchor already in use: quarkus-oidc_quarkus.oidc.roles.role-claim-path 2019-10-29T12:30:25.0014583Z [ERROR] asciidoctor: WARN: ed/config/quarkus-oidc.adoc: line 74: id assigned to anchor already in use: quarkus-oidc_quarkus.oidc.roles.role-claim-separator 2019-10-29T12:30:25.0022802Z [ERROR] asciidoctor: WARN: ed/config/quarkus-oidc.adoc: line 83: id assigned to anchor already in use: quarkus-oidc_quarkus.oidc.credentials.secret 2019-10-29T12:30:25.0052100Z [ERROR] asciidoctor: WARN: ed/config/quarkus-oidc.adoc: line 92: id assigned to anchor already in use: quarkus-oidc_quarkus.oidc.authentication.scopes 2019-10-29T12:30:25.0053213Z [ERROR] asciidoctor: WARN: ed/config/quarkus-oidc.adoc: line 101: id assigned to anchor already in use: quarkus-oidc_quarkus.oidc.application-type

@ia3andy
Copy link
Contributor

ia3andy commented Oct 29, 2019

@gsmet can we merge this?

@gsmet
Copy link
Member

gsmet commented Oct 29, 2019

Unrelated build failures. Merging to unblock Andy.

@gsmet gsmet merged commit 1819ca4 into quarkusio:master Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ia3andy ia3andy ia3andy approved these changes

Assignees
No one assigned
Labels
area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

Make CreateProject work in native mode
3 participants
@aloubyansky @ia3andy @gsmet