Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-apply docs change for Kotlin #5025

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Re-apply docs change for Kotlin #5025

merged 1 commit into from
Oct 30, 2019

Conversation

oztimpower
Copy link
Contributor

Commit 4ec22be did not merge and overrode 02b1173. Reapply 02b1173.

Log history:

  • 4ec22be Removed the legacy extensions.json and enahanced the platform json descriptor loader to load the default version from the classpath
  • 02b1173 (origin/tp/kotlin-docs-fix) Rest-assured version is specified in the bom, thus remove. Fix location of group and version for Gradle Groovy DSL.

@oztimpower
Commit 4ec22be did not merge and overrode 02b1173. Reapply 02b1173.
f05a781 
* 4ec22be Removed the legacy extensions.json and enahanced the platform json descriptor loader to load the default version from the classpath
* 02b1173 (origin/tp/kotlin-docs-fix) Rest-assured version is specified in the bom, thus remove.  Fix location of group and version for Gradle Groovy DSL.
@gsmet
Copy link
Member

gsmet commented Oct 30, 2019

Looks good to me but @geoand can you have a look to?

@gsmet gsmet added this to the 0.28.0 milestone Oct 30, 2019
geoand
geoand approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@geoand geoand merged commit 0d51d09 into quarkusio:master Oct 30, 2019
@oztimpower oztimpower deleted the tp/kotlin-docs-fix branch November 26, 2019 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oztimpower @gsmet @geoand