Test scenario for expired bearer tokens #5038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberyozkin
approved these changes
Oct 30, 2019
gsmet
reviewed
Oct 30, 2019
integration-tests/oidc/src/test/java/io/quarkus/it/keycloak/BearerTokenAuthorizationTest.java
Outdated
Show resolved
Hide resolved
|
@pedroigor Hi Pedro, can you please run |
|
Could we either fix this one or close it? We keep opening new ones and not converging on old ones: we need to iterate and merge the fixes. Thanks! |
|
@pedroigor Hi Pedro, can you please have a quick check of this PR ? |
|
@gsmet @sberyozkin missed this one badly ... Updated to use awaitility and rebased. |
|
@gsmet Hope you are OK with me merging it, the fix looked simple and sound to me :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm afraid we have some thread blocks that should be watched closely in order to avoid impacting CI execution. Any suggestion about how to better test scenarios where we need to stop execution for a while in order to check expirations and invalidations based on time would be appreciated.
Maybe introducing some utility class that we can potentially use to check and force a time ...