Unlist unlisted in list-extensions #5039
Conversation
|
@emmanuelbernard can you just confirm listExtensions should always hide "unlisted" extensions ? |
|
listExtension should always excluded the unlisted ones yes. |
| @@ -83,6 +84,10 @@ public void listExtensions(boolean all, String format, String search) throws IOE | |||
| } | |||
| } | |||
|
|
|||
| private boolean filterUnlisted(Extension e) { | |||
| return !e.getMetadata().containsKey("unlisted"); | |||
There was a problem hiding this comment.
and value true I guess.
There was a problem hiding this comment.
just that technically i can be both true (boolean) or a string 'true'. but sure let me add that together while making add honor it too.
jaeger was being listed via listExtensions. With this fix any extension with a "unlisted" key in metadata gets unlisted. i.e. the mere presence of the key makes it unlisted.
maxandersen
force-pushed
the
honorunlisted
branch
from
0815ba6
to
9fc6311
Compare
|
I've updated to have check be explicit for "true" or true and addExtension now ignores unlisted unless there is an exact match on artifactId (it never took into account groupid - something we probably want to fix/cleanup in future). |
gsmet
changed the title
jaeger was being listed via listExtensions.
With this fix any extension with a "unlisted" key in metadata gets unlisted.
i.e. the mere presence of the key makes it unlisted.