Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MP Config TCKs to only exclude two failing tests #5121

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Fix MP Config TCKs to only exclude two failing tests #5121

merged 1 commit into from
Nov 1, 2019

Conversation

kenfinnigan
Copy link
Member

  • Override test class to exclude the two methods, enabling the other methods on the class to execute

@kenfinnigan
Fix MP Config TCKs to only exclude two failing tests
9b2d71e 
- Override test class to exclude the two methods, enabling the other methods on the class to execute
@kenfinnigan kenfinnigan added this to the 0.28.0 milestone Nov 1, 2019
gsmet
gsmet approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's see what CI thinks.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 1, 2019
@kenfinnigan kenfinnigan merged commit 2425ec2 into quarkusio:master Nov 1, 2019
@kenfinnigan kenfinnigan deleted the config-fixes branch November 1, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kenfinnigan @gsmet