Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable cron expression example in scheduler guide #5127

Merged
merged 1 commit into from
Nov 3, 2019
Merged

Add configurable cron expression example in scheduler guide #5127

merged 1 commit into from
Nov 3, 2019

Conversation

machi1990
Copy link
Member

@machi1990 machi1990 commented Nov 2, 2019 •
edited
Loading

@machi1990 machi1990 mentioned this pull request Nov 2, 2019
Merged
@machi1990 machi1990 force-pushed the docs/update-scheduler-guide-with-configurable-cron branch from 9ae65b7 to 16278f2 Compare November 2, 2019 12:47
gsmet
gsmet requested changes Nov 2, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few suggestions. Some of them will impact the quickstart.

docs/src/main/asciidoc/scheduler.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/scheduler.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/scheduler.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/scheduler.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/scheduler.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/scheduler.adoc Outdated Show resolved Hide resolved
@machi1990 machi1990 force-pushed the docs/update-scheduler-guide-with-configurable-cron branch from 16278f2 to 2af12eb Compare November 2, 2019 17:11
@machi1990
Copy link
Member Author

I added a few suggestions. Some of them will impact the quickstart.

Thanks @gsmet for the review. Suggestions incorporated.

@machi1990 machi1990 force-pushed the docs/update-scheduler-guide-with-configurable-cron branch from 2af12eb to 59d9bb9 Compare November 3, 2019 09:44
@gsmet gsmet merged commit f603324 into quarkusio:master Nov 3, 2019
@gsmet
Copy link
Member

gsmet commented Nov 3, 2019

Merged, thanks!

@machi1990 machi1990 deleted the docs/update-scheduler-guide-with-configurable-cron branch November 3, 2019 17:05
@gsmet gsmet added this to the 0.28.0 milestone Nov 3, 2019
@gsmet gsmet changed the title add configurable cron expression example in scheduler guide Add configurable cron expression example in scheduler guide Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@mkouba mkouba Awaiting requested review from mkouba

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
0.28.0
Development

Successfully merging this pull request may close these issues.

Document how to make Scheduler cron configurable via config
2 participants
@machi1990 @gsmet