-
Notifications
You must be signed in to change notification settings - Fork 3k
Record every configuration marked as build time fixed #51507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
|
This resolved our issue. Thank you for the quick fix. |
1506bc4 to
d33eb7f
Compare
|
Excellent. Thank you! |
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs | Build scan |
|---|---|---|---|---|---|---|
| ✔️ | JVM Integration Tests - JDK 17 | Logs | Raw logs | 🔍 | ||
| ✔️ | JVM Integration Tests - JDK 17 Windows | Logs | Raw logs | 🔍 | ||
| ✔️ | JVM Integration Tests - JDK 21 | Logs | Raw logs | 🔍 | ||
| ✔️ | JVM Integration Tests - JDK 21 Semeru | Logs | Raw logs | 🔍 | ||
| ❌ | JVM Integration Tests - JDK 25 | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ JVM Integration Tests - JDK 25 #
- Failing: integration-tests/spring-web
📦 integration-tests/spring-web
❌ io.quarkus.it.spring.web.SpringSchedulerTest.testCount line 22 - History - More details - Source on GitHub
Details
org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:183)
at io.quarkus.it.spring.web.SpringSchedulerTest.testCount(SpringSchedulerTest.java:22)
Flaky tests - Develocity
⚙️ JVM Tests - JDK 21
📦 extensions/opentelemetry/deployment
❌ io.quarkus.opentelemetry.deployment.logs.LoggingFrameworkTest.testLog4jLogging - History
Expected log to have body <ValueString{Log4j Logging message}> but was <ValueString{Installed features: [agroal, cdi, compose, hibernate-validator, jdbc-h2, narayana-jta, opentelemetry, reactive-routes, resteasy-client, security, smallrye-context-propagation, smallrye-graphql, smallrye-health, vertx]}>-org.opentest4j.AssertionFailedError
Details
org.opentest4j.AssertionFailedError: Expected log to have body <ValueString{Log4j Logging message}> but was <ValueString{Installed features: [agroal, cdi, compose, hibernate-validator, jdbc-h2, narayana-jta, opentelemetry, reactive-routes, resteasy-client, security, smallrye-context-propagation, smallrye-graphql, smallrye-health, vertx]}>
at io.quarkus.opentelemetry.deployment.logs.LoggingFrameworkTest.testLog4jLogging(LoggingFrameworkTest.java:95)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:532)
at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:446)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
⚙️ JVM Tests - JDK 17 Windows
📦 extensions/micrometer-opentelemetry/deployment
❌ io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod - History
Stream has no elements-java.lang.IllegalArgumentException
Details
java.lang.IllegalArgumentException: Stream has no elements
at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lambda$lastReading$2(MetricDataFilter.java:213)
at java.base/java.util.Optional.orElseThrow(Optional.java:403)
at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReading(MetricDataFilter.java:213)
at io.quarkus.micrometer.opentelemetry.deployment.common.MetricDataFilter.lastReadingDataPoint(MetricDataFilter.java:231)
at io.quarkus.micrometer.opentelemetry.deployment.compatibility.MicrometerTimedInterceptorTest.testTimeMethod(MicrometerTimedInterceptorTest.java:77)
at java.base/java.lang.reflect.Method.invoke(Method.java:569)
at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:532)
📦 extensions/websockets-next/deployment
❌ io.quarkus.websockets.next.test.EchoWebSocketTest.testEchoMultiConsume - History
expected: <hello> but was: <null>-org.opentest4j.AssertionFailedError
Details
org.opentest4j.AssertionFailedError: expected: <hello> but was: <null>
at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1145)
at io.quarkus.websockets.next.test.EchoWebSocketTest.assertEcho(EchoWebSocketTest.java:148)
⚙️ MicroProfile TCKs Tests
📦 tcks/microprofile-lra
❌ org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable - History
Expecting the metric Compensated callback was called Expected: a value equal to or greater than <1> but: <0> was less than <1>-java.lang.AssertionError
Details
java.lang.AssertionError:
Expecting the metric Compensated callback was called
Expected: a value equal to or greater than <1>
but: <0> was less than <1>
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.eclipse.microprofile.lra.tck.TckRecoveryTests.assertMetricCallbackCalled(TckRecoveryTests.java:210)
at org.eclipse.microprofile.lra.tck.TckRecoveryTests.testCancelWhenParticipantIsUnavailable(TckRecoveryTests.java:195)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
⚙️ JVM Integration Tests - JDK 25
📦 integration-tests/virtual-threads/grpc-virtual-threads
❌ io.quarkus.grpc.example.streaming.VirtualThreadTest.testGrpcClient - History
1 expectation failed. Expected status code <200> but was <500>.-java.lang.AssertionError
Details
java.lang.AssertionError:
1 expectation failed.
Expected status code <200> but was <500>.
at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:499)
at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:483)
at org.codehaus.groovy.reflection.CachedConstructor.invoke(CachedConstructor.java:73)
at org.codehaus.groovy.runtime.callsite.ConstructorSite$ConstructorSiteNoUnwrapNoCoerce.callConstructor(ConstructorSite.java:108)
In #51248, we improved the recording of build time fixed configuration, but the recording of non-default values was relying on the list of property names returned by
ConfigandConfigSources.If a
ConfigSourcereported values, but not the list of names, it could cause a false positive warning of overriding a build time fixed configuration, observed in keycloak/keycloak#44599.Since we know the list of build time configuration names, we now record it using our list instead of relying on the list reported by
Config.