Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the original exception that caused classloading to fail #5344

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Include the original exception that caused classloading to fail #5344

merged 1 commit into from
Nov 9, 2019

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Nov 9, 2019

This is a very trivial change to include the original exception that caused the classloading to fail.

@machi1990 machi1990 requested a review from mkouba November 9, 2019 08:36
geoand
geoand approved these changes Nov 9, 2019
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I could have used it in one of the previous issues.
Nice catch 👌

@geoand geoand added this to the 1.1.0 milestone Nov 9, 2019
@geoand geoand merged commit c815b98 into quarkusio:master Nov 9, 2019
@jaikiran jaikiran deleted the recorder-include-ex branch November 10, 2019 12:24
@gsmet gsmet removed the backport? label Nov 14, 2019
@gsmet gsmet modified the milestones: 1.1.0, 1.0.0.Final Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@mkouba mkouba Awaiting requested review from mkouba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0.CR2
Development

Successfully merging this pull request may close these issues.
3 participants
@jaikiran @geoand @gsmet