Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail explicitly if no persistence.xml is present and no dialect can be guessed from the driver #537

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Fail explicitly if no persistence.xml is present and no dialect can be guessed from the driver #537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...sions/jpa/deployment/src/main/java/org/jboss/shamrock/jpa/HibernateResourceProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,10 @@ private Optional<String> guessDialect(Optional<String> driver) {
if ( resolvedDriver.contains("org.mariadb.jdbc.Driver")) {
return Optional.of(MariaDB103Dialect.class.getName());
}
return Optional.empty();
String error = driver.isPresent() ?
"Hibernate extension could not guess the dialect from the driver '" + resolvedDriver + "'. Add an explicit 'shamrock.hibernate.dialect' property." :
"Hibernate extension cannot guess the dialect as no JDBC driver is specified by 'shamrock.datasource.driver'";
throw new ConfigurationError(error);
}

private void enhanceEntities(final KnownDomainObjects domainObjects, BuildProducer<BytecodeTransformerBuildItem> transformers) {
Expand Down