Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate dependency from integration test module #5476

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Remove duplicate dependency from integration test module #5476

merged 1 commit into from
Nov 14, 2019

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Nov 14, 2019

This dependency is listed twice in the same module. Maven seems to not complain during a regular build, but this fails hard when trying to build subsets of the Quarkus project using Maven's -amd to build all dependant modules of a list of projects.

@Sanne Sanne added this to the 1.1.0 milestone Nov 14, 2019
@Sanne Sanne added kind/bug Something isn't working area/infra internal and infrastructure related issues labels Nov 14, 2019
machi1990
machi1990 approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@Sanne Sanne added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 14, 2019
@gsmet
Copy link
Member

gsmet commented Nov 14, 2019

Adding the backport? as the issue is also present in the 1.0 branch.

@Sanne Sanne merged commit f3a9e1c into quarkusio:master Nov 14, 2019
@Sanne Sanne deleted the DuplicateDeps branch November 14, 2019 19:41
@gsmet gsmet removed the backport? label Nov 15, 2019
@gsmet gsmet modified the milestones: 1.1.0, 1.0.0.Final Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 approved these changes

@aloubyansky aloubyansky aloubyansky approved these changes

Assignees
No one assigned
Labels
area/infra internal and infrastructure related issues kind/bug Something isn't working triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.0.0.CR2
Development

Successfully merging this pull request may close these issues.
4 participants
@Sanne @gsmet @aloubyansky @machi1990