Show more robust gradle graal configuration in docs #5510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Nov 15, 2019
| @@ -77,7 +77,7 @@ When using Gradle, we need to configure the additional build arguments in the pl | |||
| ---- | |||
| buildNative { | |||
| additionalBuildArgs = [ | |||
| '-H:ResourceConfigurationFiles=../resources/main/resources-config.json' | |||
| "-H:ResourceConfigurationFiles=${buildDir}/resources/main/resources-config.json".toString() | |||
There was a problem hiding this comment.
I don't know Gradle very well but is the toString() needed? It looks weird.
(Just asking, I suppose you added it because it was required)
There was a problem hiding this comment.
yea the toString() is needed otherwise Groovy interprets it as a groovy.lang.GString and not a java.lang.String and then we get a classcastexception. An alternative would be to do:
'-H:ResourceConfigurationFiles=' + buildDir + '/resources/main/resources-config.json'
There was a problem hiding this comment.
Exactly, groovy has its own GString which needs to be converted to regular String
aguibert
approved these changes
Nov 15, 2019
| @@ -77,7 +77,7 @@ When using Gradle, we need to configure the additional build arguments in the pl | |||
| ---- | |||
| buildNative { | |||
| additionalBuildArgs = [ | |||
| '-H:ResourceConfigurationFiles=../resources/main/resources-config.json' | |||
| "-H:ResourceConfigurationFiles=${buildDir}/resources/main/resources-config.json".toString() | |||
There was a problem hiding this comment.
yea the toString() is needed otherwise Groovy interprets it as a groovy.lang.GString and not a java.lang.String and then we get a classcastexception. An alternative would be to do:
'-H:ResourceConfigurationFiles=' + buildDir + '/resources/main/resources-config.json'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@aguibert could you also take a look?