Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow falling back to the bundled platform in case quarkus-platform-descriptor-json:jar couldn't be resolved #5517

Conversation

aloubyansky
Copy link
Member

If quarkus-platform-descriptor-json:jar couldn't be resolved and the user didn't provide any specific platform coordinates then fallback to the platform bundled with the tools

…user didn't provide any specific platform coordinates then fallback to the platform bundled with the tools
@aloubyansky aloubyansky added the area/platform Issues related to definition and interaction with Quarkus Platform label Nov 15, 2019
@aloubyansky aloubyansky added this to the 1.1.0 milestone Nov 15, 2019
@aloubyansky
Copy link
Member Author

@gsmet fyi, this should fix your issue

Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I can't verify it fixes as I can't reproduce the error @gsmet sees - I'll let him verify!

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixed my issue.

@gsmet gsmet merged commit e70441f into quarkusio:master Nov 18, 2019
@gsmet gsmet removed the backport? label Nov 18, 2019
@gsmet gsmet modified the milestones: 1.1.0, 1.0.0.Final Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants