Take into account repeated constraint annotations #5652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Nov 21, 2019
|
|
||
| @MyConstraint("value1") | ||
| @MyConstraint("value2") | ||
| public String testValue2; |
There was a problem hiding this comment.
Can you separate the tests in 2 bean classes?
Because, if at least one works, then all the constraints will be detected so we really need to test the built-in constraints and the custom constraints in 2 separate beans.
irenakezic
force-pushed
the
issue5549
branch
from
baa47e3
to
0e21bd1
Compare
gsmet
approved these changes
Nov 21, 2019
|
Looks good, thanks! Congrats for your first contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take into account repeated constraint annotations
Fixes #5549