Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - introduce ObserverTransformer build extension #6098

Merged
merged 3 commits into from
Dec 12, 2019
Merged

ArC - introduce ObserverTransformer build extension #6098

merged 3 commits into from
Dec 12, 2019

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Dec 11, 2019

No description provided.

@mkouba mkouba requested a review from manovotn December 11, 2019 10:41
manovotn
manovotn reviewed Dec 11, 2019
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, added some minor comments.
We'll also need to document this.
Last but not least, +1 for the refactoring.

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/ObserverInfo.java Outdated Show resolved Hide resolved
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Transformation.java Show resolved Hide resolved
...ndent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/ObserverTransformer.java Outdated Show resolved Hide resolved
...ndent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/ObserverTransformer.java Show resolved Hide resolved
...s/arc/processor/src/main/java/io/quarkus/arc/processor/AnnotationsTransformationContext.java Show resolved Hide resolved
@mkouba mkouba marked this pull request as ready for review December 11, 2019 16:37
@mkouba mkouba requested review from gwenneg and manovotn December 11, 2019 16:37
@gwenneg
Copy link
Member

gwenneg commented Dec 12, 2019

Thanks for this enhancement @mkouba!

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 12, 2019
@mkouba mkouba added this to the 1.2.0 milestone Dec 12, 2019
@mkouba
SmallRye FT - initialize Hystrix during RUNTIME_INIT
2c78d5d 
- veto HystrixInitializer.init() observer
- add HystrixInitializerStartup
- resolves quarkusio#6024
@mkouba mkouba merged commit 5dc868f into quarkusio:master Dec 12, 2019
@gwenneg gwenneg mentioned this pull request Dec 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

@gwenneg gwenneg Awaiting requested review from gwenneg

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.2.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkouba @gwenneg @manovotn