Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OidcTenantConfig out of the runtime package #8596

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

sberyozkin
Copy link
Member

Fixes #8347

I can update 1.4.0.Final release notes and also sent the note to the forum once this PR is merged. CC @gsmet

@sberyozkin
Copy link
Member Author

AmazonLambdaSimpleTestCase fails in one of the CIs.
I'll give it another rebase

@sberyozkin sberyozkin force-pushed the oidc_tenant_config_api branch from c839ca6 to 59c5ce3 Compare April 16, 2020 17:25
Copy link
Contributor

@pedroigor pedroigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have a specific object to build this configuration when multi-tenancy is being used. It would help to improve encapsulation and remove those getters/setters that are kind of redundant now.

I'm approving because I think you mentioned we are going to handle this in the future. But the way it is now users can set config properties in different ways when using multi-tenancy.

@sberyozkin
Copy link
Member Author

@pedroigor Hi, you had an idea awhile back that we can introduce a builder API, I might give it a go later.

@sberyozkin
Copy link
Member Author

@pedroigor @gsmet I keep getting a resteasy deployment test failure, Security2 tests pass:
https://github.com/quarkusio/quarkus/pull/8596/checks?check_run_id=592986982

I'll rebase again just to try to get a total green, but will merge, unless there will be more review comments if the same reasteasy test fails, as it has to make it into 1.4.0.Final if it to make it at all :-)

@sberyozkin sberyozkin force-pushed the oidc_tenant_config_api branch from 59c5ce3 to 108ed93 Compare April 16, 2020 21:49
@sberyozkin
Copy link
Member Author

The same resteasy deployment failure, so I'll just go ahead or else it won't make it at all.

@sberyozkin sberyozkin merged commit 1461a10 into quarkusio:master Apr 17, 2020
@gsmet gsmet modified the milestones: 1.5.0, 1.4.0.Final Apr 20, 2020
@sberyozkin
Copy link
Member Author

sberyozkin commented Apr 21, 2020

@gsmet Can you explain why it is not backported ? I've updated the 1.4 migration guide thinking it was already backported (or will be shortly)

@sberyozkin
Copy link
Member Author

@gsmet OK, got it. Sorry I missed that the backport was already done, could've checked

@sberyozkin sberyozkin deleted the oidc_tenant_config_api branch September 16, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move OidcTenantConfig out of the runtime package
3 participants