Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Fix maven classifier in dev mode #9337

Closed
wants to merge 1 commit into from
Closed

WIP: Fix maven classifier in dev mode #9337

wants to merge 1 commit into from

Conversation

rmanibus
Copy link
Contributor

No description provided.

@boring-cyborg boring-cyborg bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label May 15, 2020
@rmanibus rmanibus changed the title First blood Fix 9335 May 15, 2020
@rmanibus rmanibus changed the title Fix 9335 Fix maven classifier in dev mode May 15, 2020
@rmanibus rmanibus mentioned this pull request May 15, 2020
Closed
gsmet
gsmet requested changes May 15, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you please make your commit comment meaningful?

Other than that, I will let Alexey review.

@gsmet gsmet requested a review from aloubyansky May 15, 2020 10:20
@rmanibus
Copy link
Contributor Author

Sorry it's not ready yet. I will amend it when it's working!

@aloubyansky aloubyansky changed the title Fix maven classifier in dev mode WIP: Fix maven classifier in dev mode May 15, 2020
@rmanibus rmanibus closed this May 15, 2020
@gsmet gsmet added the triage/invalid This doesn't seem right label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet requested changes

@aloubyansky aloubyansky Awaiting requested review from aloubyansky

Assignees
No one assigned
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins triage/invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmanibus @gsmet