Skip to content

Conversation

@loicmathieu
Copy link
Contributor

Some small implementation improvements for Azure function HTTP and Amazon lambda HTTP.
This align the implementation with Google Cloud Functin HTTP.

  • Use a ByteArrayOutputStream of 8k as it's the admitted default ideal size (this is the size used inside the JDK by default)
  • Close the ByteArrayOutputStream gracefully

@gsmet
Copy link
Member

gsmet commented Jun 16, 2020

/cc @patriot1burke

@loicmathieu loicmathieu force-pushed the azur-aws-function-improvements branch from 84fe38d to 05cd043 Compare June 16, 2020 15:56
@gsmet
Copy link
Member

gsmet commented Jun 25, 2020

@patriot1burke are you good with it now?

@loicmathieu
Copy link
Contributor Author

@patriot1burke can we merge this one to align the buffer size for AWS, Azure and Google ?
The choosen size is the default used inside the JVM so it should be a sane default.

@gsmet gsmet changed the title Azure and AWS function improvements Align buffer size for Azure and AWS functions Jul 29, 2020
@gsmet gsmet added this to the 1.7.0 - master milestone Jul 29, 2020
@gsmet gsmet merged commit c474979 into quarkusio:master Jul 29, 2020
@loicmathieu loicmathieu deleted the azur-aws-function-improvements branch July 29, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants