-
Notifications
You must be signed in to change notification settings - Fork 394
Add Commhaus Foundation logo to footer #2326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🎊 PR Preview c6866be has been successfully built and deployed to https://quarkus-site-pr-2326-preview.surge.sh
|
I'm not sure having the image part transparent is a good choice? |
@gsmet - added a tinted background behind the CF logo to separate from the quarkus footer background image. |
I've adjusted the opacity to be more visible on the mac laptop screen. The Commonhaus Foundation has it's own logo spacing requirements. In order to make it easier for projects, we've made custom CF logos with project tags (so they don't need to worry about adding enough spacing for the logo on their sites). https://github.com/commonhaus/artwork/tree/main/foundation/brand/project/svg The text alignments for the "foo is a Commonhaus Foundation project" is part of this file and is consistent across the projects. |
Maybe if that text isn't going to align with the rest of the text in the column, and if the background for the text isn't going to be the same as what's in the rest of the column, the logo should span a couple of columns? Or maybe it could go in the footer, where the background difference would be less jarring and the alignment wouldn't be an issue? |
FWIW, my comment about the background of the logo was solely about the image part: the house with the tree. Having our Quarkus background in the middle of the lines of the house/tree looked really odd. |
Maybe the tinted background could be just behind the 'image' part of the image, so we avoid the awkwardness of some text having a black box behind it. That doesn't fix the alignment issues on the bottom row of text, but it would be a lot better, IMO. Or, alternatively, we could move the black box to sit on top of a black area, rather than the coloured area. |
I agree. The CF logo wasn't designed to be on top of an image. @holly-cummins @gsmet @maxandersen Solutions...
|
** If you are updating a guide, please submit your pull request to the main repository: https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc **