Skip to content

Add Commhaus Foundation logo to footer #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

insectengine
Copy link
Collaborator

** If you are updating a guide, please submit your pull request to the main repository: https://github.com/quarkusio/quarkus/tree/main/docs/src/main/asciidoc **

Copy link

github-actions bot commented Jun 3, 2025

🎊 PR Preview c6866be has been successfully built and deployed to https://quarkus-site-pr-2326-preview.surge.sh

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@gsmet
Copy link
Member

gsmet commented Jun 3, 2025

I'm not sure having the image part transparent is a good choice?

@insectengine
Copy link
Collaborator Author

@gsmet - added a tinted background behind the CF logo to separate from the quarkus footer background image.

@holly-cummins
Copy link
Contributor

I didn't see it part-transparent, but I think the black blackground looks a bit inconsistent with what we've done elsewhere on the footer in terms of the text. 'CommonHaus Foundation' and 'Quarkus is a CommonHaus project' is the only text that's on a black background. Even the 'Quarkus' logotype has a transparent background.

Also, with the background, the black block and surrounding text doesn't seem to be aligned quite right. On the left side the black border is aligned with the rest of the text, so the commonhaus text is indented. But on the right side the black border is roughly aligned with the right edge of the text. The right margins are ragged so 'edge' is a loose concept; I suspect in terms of layout everything actually is aligned, but the visual effect is misaligned.

image

@insectengine
Copy link
Collaborator Author

I've adjusted the opacity to be more visible on the mac laptop screen.
Screenshot 2025-06-04 at 10 59 38 AM

The Commonhaus Foundation has it's own logo spacing requirements. In order to make it easier for projects, we've made custom CF logos with project tags (so they don't need to worry about adding enough spacing for the logo on their sites).

https://github.com/commonhaus/artwork/tree/main/foundation/brand/project/svg

The text alignments for the "foo is a Commonhaus Foundation project" is part of this file and is consistent across the projects.

@holly-cummins
Copy link
Contributor

I've adjusted the opacity to be more visible on the mac laptop screen. Screenshot 2025-06-04 at 10 59 38 AM

The Commonhaus Foundation has it's own logo spacing requirements. In order to make it easier for projects, we've made custom CF logos with project tags (so they don't need to worry about adding enough spacing for the logo on their sites).

https://github.com/commonhaus/artwork/tree/main/foundation/brand/project/svg

The text alignments for the "foo is a Commonhaus Foundation project" is part of this file and is consistent across the projects.

Maybe if that text isn't going to align with the rest of the text in the column, and if the background for the text isn't going to be the same as what's in the rest of the column, the logo should span a couple of columns? Or maybe it could go in the footer, where the background difference would be less jarring and the alignment wouldn't be an issue?

@gsmet
Copy link
Member

gsmet commented Jun 25, 2025

FWIW, my comment about the background of the logo was solely about the image part: the house with the tree. Having our Quarkus background in the middle of the lines of the house/tree looked really odd.

@holly-cummins
Copy link
Contributor

Maybe the tinted background could be just behind the 'image' part of the image, so we avoid the awkwardness of some text having a black box behind it. That doesn't fix the alignment issues on the bottom row of text, but it would be a lot better, IMO. Or, alternatively, we could move the black box to sit on top of a black area, rather than the coloured area.

@insectengine
Copy link
Collaborator Author

insectengine commented Jun 25, 2025

FWIW, my comment about the background of the logo was solely about the image part: the house with the tree. Having our Quarkus background in the middle of the lines of the house/tree looked really odd.

I agree. The CF logo wasn't designed to be on top of an image.

@holly-cummins @gsmet @maxandersen

Solutions...

  1. We drop the background image from the project footer. We currently drop it for mobile sizes anyway. A side effect is we save some download time for the webpage. Additionally, this keeps the CF logo visible across the site (see screenshot).

Screenshot 2025-06-25 at 11 33 44 AM

  1. We use the CF horizontal logo (without the Quarkus tagline) and put it in the black bar RH footer. This will cause the footer to grow in height a bit. Additionally, this keeps the CF logo visible across the site (see screenshot).

Screenshot 2025-06-25 at 10 16 04 AM

  1. Third option is we remove it from the footers and add it to the feedback band. This keeps the homepage roughly the same as it currently is and doesn't add additional scroll. The drawback is this is only on the homepage, unlike it being on the project footer or RH black bar footer being on all pages (see screenshot).

Screenshot 2025-06-25 at 10 45 55 AM

  1. We add a full Commonhaus Band on the homepage. This will increase the overall scroll for the homepage, but it allow for us to give a little more description to why we made the move. This also has the drawback as only being visible on the homepage (see screenshot).

Screenshot 2025-06-25 at 11 05 01 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants