add benefactors page #2387
add benefactors page #2387
Conversation
|
🙈 The PR is closed and the preview is expired. |
|
The preview is failing because the application is too large, which does make reviews harder. I guess we must have just tipped over a threshold, unrelated to this PR. @gsmet, are you able to do a bit more of your payload-shrinking magic to get things going again? |
|
At least the glass is partially full :)
🥇
Good call, Erin reminded me whe'd need specific permissions for logo usage. Commonhaus has a standard form to do this, but would be good to not wait for all that. |
_includes/benefactors.html
Outdated
| <div class="grid-wrapper"> | ||
| <div class="width-4-12 width-12-12-m"> | ||
| <h3>IBM</h3> | ||
| <p>IBM strengthens its Java and Quarkus commitment by moving Red Hat engineers to IBM. This ensures dedicated resources for Quarkus's growth, deepening IBM's open-source involvement and focus on cloud-native Java for enterprises.</p> |
There was a problem hiding this comment.
grammar-nit:
Tense of this sentence is weird. "by moving" ... we moved. This sounds like a press-release, and that language applies at instant of publishing, and then is past..
There was a problem hiding this comment.
Might also be worthy to call out that IBM is employing most of the core Quarkus engineers, and funding any resources they need?
There was a problem hiding this comment.
I don't think we need to be that specific do we? I think the current content makes that implication.
There was a problem hiding this comment.
fair enough, yes. I just wonder if this isn't excess detail - our users don't care much that we've been transferred, it's a very minor detail to them - they probably prefer the short factual version: IBM employs the people.
But I'm nitpicking, either is fine for me.
|
@Sanne @gsmet @holly-cummins - When do we want to merge this new section? We'll need to coordinate with Holly to add the navigation to the Extensions app. |
|
@Sanne are you ok merging? |
In principle yes, no objections. I haven't explicitly merged it as I haven't been able to see the preview? |
Co-authored-by: Sanne Grinovero <sanne.grinovero@gmail.com>
Co-authored-by: Sanne Grinovero <sanne.grinovero@gmail.com>
insectengine
force-pushed
the
benefactors
branch
from
48c180b to
95b7f4f
Compare
|
@Sanne - think I resolved the conflict. |
|
Great, thanks all. Let's merge it then! |
Added a first cut at the benefactors page.
I've chosen to NOT include any company logos at this point to avoid the need for approvals for usage (as described in several company logo guides).
resolves #2357