Improve the stress scripts #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
holly-cummins
left a comment
holly-cummins
left a comment
There was a problem hiding this comment.
The changes to stress.sh make a lot of sense, and I think are on the right side of the 'understandability vs robustness' tradeoff.
For stress-all.sh, what's the reasoning for duplicating stress.sh rather than just calling out to it? Is it to be able to redirect just parts of it to a file?
Member
Author
|
I mostly kept them separate at this point as I assumed that you probably wouldn't want to merge If you think you'd like to have both I can make sure that they share functions and tidy up a little. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.