Adding support for reporting service information #131
Conversation
| @@ -25,6 +25,7 @@ shared-bus = { version = "0.2.0-alpha.1", features = ["cortex-m"] } | |||
| usb-device = "0.2.6" | |||
| postcard = "0.5.1" | |||
| crc-any = { version = "2.3.5", default-features = false } | |||
| panic-persist = { git = "https://github.com/jamesmunns/panic-persist", branch = "master", features = ["custom-panic-handler"] } | |||
There was a problem hiding this comment.
James Munns said he would push the master branch to a new release later today, so we should wait and update when that gets pushed.
| @@ -25,6 +25,7 @@ shared-bus = { version = "0.2.0-alpha.1", features = ["cortex-m"] } | |||
| usb-device = "0.2.6" | |||
| postcard = "0.5.1" | |||
| crc-any = { version = "2.3.5", default-features = false } | |||
| panic-persist = { git = "https://github.com/jamesmunns/panic-persist", branch = "master", features = ["custom-panic-handler"] } | |||
| @@ -152,6 +156,25 @@ impl SerialTerminal { | |||
| ); | |||
| } | |||
|
|
|||
| Request::ServiceInfo => { | |||
There was a problem hiding this comment.
Also print version, release/debug, features and commit hash (through build.rs I guess). That makes the dump much more useful.
There was a problem hiding this comment.
Service command has now become much more comprehensive:
> service
Version : v0.1.0-50-gf59fce4
Git revision : f59fce4f44f3790adf26d6be25a5917cb32793af-dirty
Features : UNSTABLE
Panic Info : None
Watchdog Detected : false
>
Version indicates the output of git describe --tags, Git revisionappends the-dirtyflag to indicate if untracked changes are present, andFeatures` is a comma-separated list of all enabled features. Other values self-explanatory.
There was a problem hiding this comment.
Maybe just use built (dev-dependency) for that. Also makes the git parsing and command execution somewhat more robust.
There was a problem hiding this comment.
@jordens I was poking around with built and discovered an issue with cargo that prevents us from using built along with stable cargo - built enables std-features in serde, which is then (incorrectly) propagated to our application, which results in the app build failing if we use built in the [build-dependencies] section.
- Features of dependencies are enabled if they're enabled in build-dependencies; breaks no_std libs rust-lang/cargo#5730
- Tracking issue for -Z features=host_dep rust-lang/cargo#7915
Necessary cargo changes were merged recently, but we'd have to move to nightly cargo.
We can move over to nightly cargo, but that would not be super optimal. We could alternatively leave this minimal implementation and spawn an issue to update to built when cargo stabilizes the fix.
There was a problem hiding this comment.
Ah. I wasn't aware that crate features were also unified between dependencies and build-dependencies. That sounds bad.
There was a problem hiding this comment.
It's a bug that just recently got fixed, but is not quite yet on stable cargo
This fixes #93
As a debug tool, I've added in
panic-persistand refactored how the watchdog operates.With the new behavior, the following functionality is added:
servicecommand is added to print detection of watchdogs and/or panic messagesserviceUSB command, Booster is power cycled, or if the user manually resets interlocks using theInterlock Resetbuttonserviceis issued over USBThese changes are intended to provide us a minimal persistent state for debugging faulty Boosters in the field to aid in diagnosing future issues.
Testing
servicecommand reported it. Future calls toserviceindicated no watchdog was presentservicecommand output. I verified it was cleared afterwards.