Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockin #222

Merged
merged 15 commits into from
Jan 13, 2021
Merged

Lockin #222

merged 15 commits into from
Jan 13, 2021

Conversation

matthuszagh
Copy link
Contributor

Integrate PLL and integer math to lock-in functionality.

@matthuszagh matthuszagh requested a review from jordens January 9, 2021 18:51
Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest you try to actually use the code in the processing ISR in main.rs. That should show whether these wrappers are actually convenient or whether the code would be much shorter and easier to understand if they were inlined.

The moving of the batch and timer constants here doesn't seem right. dsp should be standalone and should not dictate the application. Inlining the code may quickly make the TODO redundant.

@matthuszagh matthuszagh requested a review from jordens January 13, 2021 04:23
Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Once TimestampHandler is factored out into dsp (see below), let's move the remaining changes to main.rs into a new PR (e.g. lockin-bin). Then this dsp PR can land right now and we can use the lockin-bin as a trial for the multiple-bin refactoring.

@matthuszagh matthuszagh requested a review from jordens January 13, 2021 17:43
Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@jordens jordens merged commit 1d0e1f9 into quartiq:master Jan 13, 2021
@matthuszagh matthuszagh deleted the lockin branch January 13, 2021 17:49
@matthuszagh matthuszagh mentioned this pull request Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants