-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lockin #222
Lockin #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest you try to actually use the code in the processing ISR in main.rs. That should show whether these wrappers are actually convenient or whether the code would be much shorter and easier to understand if they were inlined.
The moving of the batch and timer constants here doesn't seem right. dsp
should be standalone and should not dictate the application. Inlining the code may quickly make the TODO redundant.
…eriod Having both is not really redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Once TimestampHandler
is factored out into dsp
(see below), let's move the remaining changes to main.rs
into a new PR (e.g. lockin-bin
). Then this dsp
PR can land right now and we can use the lockin-bin
as a trial for the multiple-bin refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
Integrate PLL and integer math to lock-in functionality.