rj/pounder fixes #371
Merged
rj/pounder fixes #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure that eatch call to latch() generates a rising edge, first assert low, then high, not the other way round.
Before the discriminant was used despite being a compiler implementaiton detail. This now fixes the discriminant to match byte index in the attenuator shift register and latch-enable index of the gpio extender.
This is currently unused but it's better to have enums than a set of assorted constants.
* master: adapt to new heapless/serde-json-core after const-generics Bump serde-json-core from 0.3.0 to 0.4.0 build(deps): bump heapless from 0.6.1 to 0.7.1
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One big issue was the apparently broken mcp23017
digital_write. I couldn't get it to work.For now, and since (a) we aren't handling the other pins in any configurable way, and (b) the readback-style modification is slow let's just to whole-port writes of constants.