Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pandoc 3.2.1] Check for change on table as odd / even / header classes have been removed #10607

Closed
cderv opened this issue Aug 26, 2024 · 2 comments · Fixed by #10906
Closed
Labels
enhancement New feature or request html Issues with HTML and related web technology (html/css/scss) tables Issues with Tables including the gt integration themes Related to HTML theming or any other style related issue (like highlight-style)
Milestone

Comments

@cderv
Copy link
Collaborator

cderv commented Aug 26, 2024

Change happened at

It caused issues with R Markdown

It will be important to check this is not impact too much Quarto. We leverages the class in some places like

// add .table class to pandoc tables
const tableHeaders = doc.querySelectorAll("tbody > tr:first-child.odd");

CSS will need to be updated to

thead tr { /* targets previous header class */ }
tbody tr:nth-child(2n) { /* targets previous even class*/ }
@cderv cderv added tables Issues with Tables including the gt integration html Issues with HTML and related web technology (html/css/scss) themes Related to HTML theming or any other style related issue (like highlight-style) labels Aug 26, 2024
@cderv cderv added this to the Future milestone Aug 26, 2024
@mcanouil mcanouil added the enhancement New feature or request label Aug 26, 2024
@cscheid cscheid modified the milestones: Future, v1.6 Aug 26, 2024
@cscheid
Copy link
Collaborator

cscheid commented Aug 26, 2024

Putting this back to v1.6 in case we merge the new Pandoc by then.

@cderv
Copy link
Collaborator Author

cderv commented Sep 27, 2024

Note that this will probably be solved while dealing with

following the pandoc's update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request html Issues with HTML and related web technology (html/css/scss) tables Issues with Tables including the gt integration themes Related to HTML theming or any other style related issue (like highlight-style)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants