-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html tables rendered from markdown don't look right with latest pandoc (3.3) #2567
Labels
theme: pandoc
concerns upstream pandoc
Comments
Should be fixed now. Thanks for the report! You can test the development version via remotes::install_github('rstudio/rmarkdown') |
Thanks for the post. My Pandoc version is 3.2.1. |
@franceskoi The fix applies to Pandoc >= 3.2.1, so you need to install the dev version mentioned above. Thanks! |
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this issue
Oct 17, 2024
Merge remote-tracking branch 'rstudio/main' into jg-devel # By Yihui Xie (4) and others # Via GitHub * rstudio/main: parameters with `choices` and `multiple = TRUE` should use a `select` input (rstudio#2576) Add support for `child=c("child.Rmd")` in find_external_resources() (rstudio#2575) Support new Pandoc 3.4 behavior with GFM math (rstudio#2573) consistent dev install instructions (rstudio#2571) Update actions/checkout to v4 (rstudio#2570) start the next version CRAN release v2.28 update tests for lua filters accordingly fix rstudio#2567: add classes `odd`, `even`, and `header` back to table rows for Pandoc >= 3.2.1 # Conflicts: # DESCRIPTION # NEWS.md
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this issue
Oct 17, 2024
* jg-devel: parameters with `choices` and `multiple = TRUE` should use a `select` input (rstudio#2576) Add support for `child=c("child.Rmd")` in find_external_resources() (rstudio#2575) Support new Pandoc 3.4 behavior with GFM math (rstudio#2573) consistent dev install instructions (rstudio#2571) Update actions/checkout to v4 (rstudio#2570) start the next version CRAN release v2.28 update tests for lua filters accordingly fix rstudio#2567: add classes `odd`, `even`, and `header` back to table rows for Pandoc >= 3.2.1
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this issue
Oct 17, 2024
* rstudio-main: parameters with `choices` and `multiple = TRUE` should use a `select` input (rstudio#2576) Add support for `child=c("child.Rmd")` in find_external_resources() (rstudio#2575) Support new Pandoc 3.4 behavior with GFM math (rstudio#2573) consistent dev install instructions (rstudio#2571) Update actions/checkout to v4 (rstudio#2570) start the next version CRAN release v2.28 update tests for lua filters accordingly fix rstudio#2567: add classes `odd`, `even`, and `header` back to table rows for Pandoc >= 3.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am running
rmarkdown
withinR
. In the end it's callingpandoc
to create html output. The command printed on the console is like that:I have two environments, an old one with pandoc 3.1.3 and a new one with 3.3. Both environments produce I believe a valid
.md
file with a table that looks likeHowever, the new pandoc (3.3) makes ugly html tables, e.g.:
While the older one is what I expect:
I've tracked the problem to the change in pandoc 3.2.1, I believe.
It got rid of header, odd, even classes on tr (jgm/pandoc#9376) in version 3.2.1 (linked from https://pandoc.org/releases.html). If I add these "classes" manually back to the final html, it then looks fine.
Here on the left is new version, without "classes", and on the right it's my manual edits, adding "classes":
Adding the classes back, as on the right, fixes the issue and the table looks good in the web browsers.
I've first submitted this issue to
pandoc
developers (jgm/pandoc#10073) however they said that I "may need to consult with RMarkdown maintainers, who will know more about how the CSS is applied; they will need to update things, probably, to work with the new pandoc defaults.". This is what I'm doing now.Also, it might be that this is related to #2566
Pandoc version 3.3 (on Linux)
rmarkdown 2.27
knitr 1.48
The text was updated successfully, but these errors were encountered: