Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website brand: logo from page-level brand metadata is not shown #11309

Open
gordonwoodhull opened this issue Nov 4, 2024 · 3 comments
Open
Assignees
Labels
brand `_brand.yml` bug Something isn't working html Issues with HTML and related web technology (html/css/scss)
Milestone

Comments

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Nov 4, 2024

This does not show the logo in html, but it works for typst:

logo-embedded.qmd

---
title: logo across formats
format:
  html: default
  typst:
    keep-typ: true
brand:
  logo:
    images:
      quarto:
        path: quarto.png
        alt: quarto logo
      posit:
        path: posit-logo-2024.svg
        alt: posit logo
    medium: quarto
    large: posit
---

{{< lipsum 4 >}}

_quarto.yml

project:
  type: website
website:
  sidebar:
    style: "docked"

    contents: []

However if I move _brand.yml to its own file

_brand.yml

logo:
  images:
    quarto:
      path: quarto.png
      alt: quarto logo
    posit:
      path: posit-logo-2024.svg
      alt: posit logo
  medium: quarto
  large: posit

logo-linked.qmd

---
title: logo across formats
format:
  html: default
  typst: default
---

{{< lipsum 4 >}}

This displays the logo in both formats.

(I have a feeling I have created cross-format compatibility bugs by allowing logo to be an object for typst, ran into this bug on the way.)

@gordonwoodhull gordonwoodhull added the bug Something isn't working label Nov 4, 2024
@gordonwoodhull gordonwoodhull added this to the v1.6 milestone Nov 4, 2024
@mcanouil mcanouil added html Issues with HTML and related web technology (html/css/scss) brand `_brand.yml` labels Nov 5, 2024
@cscheid
Copy link
Collaborator

cscheid commented Nov 6, 2024

I can't seem to repro this one. @gordonwoodhull let's go over this in person tomorrow?

@cscheid cscheid added the needs-discussion Issues that require a team-wide discussion before proceeding further label Nov 6, 2024
@gordonwoodhull
Copy link
Contributor Author

Sure... I am likely misunderstanding something, but I can still repro.

@cscheid cscheid modified the milestones: v1.6, v1.7 Nov 14, 2024
@gordonwoodhull gordonwoodhull removed the needs-discussion Issues that require a team-wide discussion before proceeding further label Nov 15, 2024
@gordonwoodhull gordonwoodhull changed the title embedded brand metadata does not show logo in html output logo from page-level brand metadata is not shown Nov 18, 2024
@gordonwoodhull
Copy link
Contributor Author

gordonwoodhull commented Nov 18, 2024

As expected, the logo also does not work for brand specified at the website page level with

brand: page-brand.yml

Typography and colors do work at page level (either embedded or explicit brand file).

Repro: https://github.com/gordonwoodhull/brand-acid-test

I looked at the implementation and it would mean loading the logo into the navbar or sidebar later on at the page level, after the project is initialized. Which would be messy because currently we're trying to initialize these project-level features only once.

But I reckon someone will eventually want this, e.g. if they have multiple projects with different logos on a site.

@gordonwoodhull gordonwoodhull changed the title logo from page-level brand metadata is not shown website brand: logo from page-level brand metadata is not shown Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brand `_brand.yml` bug Something isn't working html Issues with HTML and related web technology (html/css/scss)
Projects
None yet
Development

No branches or pull requests

3 participants